From: Sven Eckelmann <sven.eckelmann@gmx.de>
To: b.a.t.m.a.n@lists.open-mesh.org
Cc: Marek Lindner <lindner_marek@yahoo.de>
Subject: Re: [B.A.T.M.A.N.] batman-adv gateway handling
Date: Sat, 30 Oct 2010 14:14:02 +0200 [thread overview]
Message-ID: <201010301414.06280.sven.eckelmann@gmx.de> (raw)
In-Reply-To: <201010240313.35215.lindner_marek@yahoo.de>
[-- Attachment #1: Type: Text/Plain, Size: 2441 bytes --]
[PATCH 1/8] batman-adv: remove redundant gw_node_list_free() function
> @@ -315,32 +315,20 @@ void gw_node_purge_deleted(struct bat_priv *bat_priv)
> spin_lock_bh(&bat_priv->gw_list_lock);
>
> hlist_for_each_entry_safe(gw_node, node, node_tmp,
> - &bat_priv->gw_list, list) {
> - if ((gw_node->deleted) &&
> - (time_after(jiffies, gw_node->deleted + timeout))) {
> -
> - hlist_del_rcu(&gw_node->list);
> - call_rcu(&gw_node->rcu, gw_node_free_rcu);
> - }
> - }
> -
> - spin_unlock_bh(&bat_priv->gw_list_lock);
> -}
> -
> -void gw_node_list_free(struct bat_priv *bat_priv)
> -{
> - struct gw_node *gw_node;
> - struct hlist_node *node, *node_tmp;
> + &bat_priv->gw_list, list) {
> + if (((!gw_node->deleted) ||
> + (time_after(jiffies, gw_node->deleted + timeout))) &&
> + atomic_read(&bat_priv->mesh_state) == MESH_ACTIVE)
> + continue;
This should be time_before.
[PATCH 4/8] batman-adv: move gateway bandwidth into its own sysfs file
> @@ -293,12 +293,38 @@ static ssize_t show_gw_mode(struct kobject *kobj,
> struct attribute *attr, }
>
> static ssize_t store_gw_mode(struct kobject *kobj, struct attribute *attr,
> - char *buff, size_t count)
> + char *buff, size_t count)
Why was the space removed?
> + if ((strnicmp(tmp_ptr, "kbit", 4) == 0) ||
> + (multi > 1))
Why this indentation? And This should be on a single line (or I count wrong).
[PATCH 5/8] batman-adv: cleanup gw mode sysfs file to only accept one value
> + if ((gw_mode_tmp == GW_MODE_CLIENT) &&
> + (atomic_read(&bat_priv->gw_sel_class) == 0))
> + atomic_set(&bat_priv->gw_sel_class, 20);
> +
> + if ((gw_mode_tmp == GW_MODE_SERVER) &&
> + (atomic_read(&bat_priv->gw_bandwidth) == 0))
> + atomic_set(&bat_priv->gw_bandwidth, 41);
Why setting that here? And why do you set gw_sel_class here to 20 (if it is 0
before) and in softif_create to 0? Shouldn't it be set to 20 in softif_create
instead?
I don't see a big problem at the moment.
Best regards,
Sven
[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2010-10-30 12:14 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-24 1:13 [B.A.T.M.A.N.] batman-adv gateway handling Marek Lindner
2010-10-24 1:14 ` [B.A.T.M.A.N.] [PATCH 1/8] batman-adv: remove redundant gw_node_list_free() function Marek Lindner
2010-10-24 1:14 ` [B.A.T.M.A.N.] [PATCH 2/8] batman-adv: gateways silently drop DHCP requests Marek Lindner
2010-10-24 1:14 ` [B.A.T.M.A.N.] [PATCH 3/8] batman-adv: move gateway selection class into its own sysfs file Marek Lindner
2010-10-24 1:14 ` [B.A.T.M.A.N.] [PATCH 4/8] batman-adv: move gateway bandwidth " Marek Lindner
2010-10-24 1:14 ` [B.A.T.M.A.N.] [PATCH 5/8] batman-adv: cleanup gw mode sysfs file to only accept one value Marek Lindner
2010-10-24 1:14 ` [B.A.T.M.A.N.] [PATCH 6/8] batctl: support new gateway sysfs API Marek Lindner
2010-10-24 1:14 ` [B.A.T.M.A.N.] [PATCH 7/8] batman-adv: document gateway sysfs ABI Marek Lindner
2010-10-24 1:14 ` [B.A.T.M.A.N.] [PATCH 8/8] batman-adv: add gateway IPv6 support by filtering DHCPv6 messages Marek Lindner
2010-11-03 18:43 ` Linus Lüssing
2010-10-30 12:14 ` Sven Eckelmann [this message]
2010-10-31 15:10 ` [B.A.T.M.A.N.] batman-adv gateway handling Marek Lindner
2010-10-31 15:55 ` Sven Eckelmann
2010-11-01 11:14 ` Marek Lindner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201010301414.06280.sven.eckelmann@gmx.de \
--to=sven.eckelmann@gmx.de \
--cc=b.a.t.m.a.n@lists.open-mesh.org \
--cc=lindner_marek@yahoo.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox