From: Marek Lindner <lindner_marek@yahoo.de>
To: b.a.t.m.a.n@lists.open-mesh.org
Cc: devel@driverdev.osuosl.org, Tobias Klauser <tklauser@distanz.ch>,
Greg Kroah-Hartman <gregkh@suse.de>,
Simon Wunderlich <siwu@hrz.tu-chemnitz.de>
Subject: Re: [B.A.T.M.A.N.] [PATCH] staging: batman-adv: Use linux/etherdevice.h address helper functions
Date: Wed, 3 Nov 2010 13:00:59 +0100 [thread overview]
Message-ID: <201011031301.00736.lindner_marek@yahoo.de> (raw)
In-Reply-To: <20101103102512.GD10579@distanz.ch>
On Wednesday 03 November 2010 11:25:12 Tobias Klauser wrote:
> I was refering to the following part of the patch:
>
> - if (is_bcast(ethhdr->h_dest) || is_mcast(ethhdr->h_dest)) {
> + if (is_multicast_ether_addr(ethhdr->h_dest)) {
>
> I think this change should be legitimate as the same branch is done for
> multicast and broadcast addresses.
Soon we will have different code paths for broadcast and multicast right at
this spot as multicast can be optimized further. But I think we can merge the
change for the time being.
Regards,
Marek
prev parent reply other threads:[~2010-11-03 12:00 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-03 9:59 [B.A.T.M.A.N.] [PATCH] staging: batman-adv: Use linux/etherdevice.h address helper functions Tobias Klauser
2010-11-03 10:12 ` Sven Eckelmann
2010-11-03 10:25 ` Tobias Klauser
2010-11-03 10:56 ` Sven Eckelmann
2010-11-03 11:04 ` Sven Eckelmann
2010-11-03 12:00 ` Marek Lindner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201011031301.00736.lindner_marek@yahoo.de \
--to=lindner_marek@yahoo.de \
--cc=b.a.t.m.a.n@lists.open-mesh.org \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@suse.de \
--cc=siwu@hrz.tu-chemnitz.de \
--cc=tklauser@distanz.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox