Re: [B.A.T.M.A.N.] [PATCH] staging: batman-adv: Use linux/etherdevice.h address helper functions

Marek Lindner
2010-11-03T12:00:59Z

On Wednesday 03 November 2010 11:25:12 Tobias Klauser wrote:
> I was refering to the following part of the patch:
>
> - if (is_bcast(ethhdr->h_dest) || is_mcast(ethhdr->h_dest)) {
> + if (is_multicast_ether_addr(ethhdr->h_dest)) {
>
> I think this change should be legitimate as the same branch is done for
> multicast and broadcast addresses.

Soon we will have different code paths for broadcast and multicast right at
this spot as multicast can be optimized further. But I think we can merge the
change for the time being.

Regards,
Marek