Re: [B.A.T.M.A.N.] patch "staging: batman-adv: Use linux/etherdevice.h address helper functions" added to staging tree

[Marek Lindner <lindner_marek@yahoo.de>]

Greg,

> The patch is only compile-tested.

[..]

> diff --git a/drivers/staging/batman-adv/main.c
> b/drivers/staging/batman-adv/main.c index 0587940..6ea6420 100644
> --- a/drivers/staging/batman-adv/main.c
> +++ b/drivers/staging/batman-adv/main.c
> @@ -149,7 +149,7 @@ void dec_module_count(void)
> 
>  int compare_orig(void *data1, void *data2)
>  {
> -	return (memcmp(data1, data2, ETH_ALEN) == 0 ? 1 : 0);
> +	return (compare_ether_addr(data1, data2) == 0 ? 1 : 0);
>  }

I'm wondering why you accepted this patch despite the raised objections 
regarding alignment problems. [1][2]
Is there something you know that we overlooked ? We haven't heard from Thomas 
or you since the alignment question came on the table. 

Cheers,
Marek

[1]https://lists.open-mesh.org/pipermail/b.a.t.m.a.n/2010-November/003640.html
[2]https://lists.open-mesh.org/pipermail/b.a.t.m.a.n/2010-November/003643.html