public inbox for b.a.t.m.a.n@lists.open-mesh.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@suse.de>
To: Marek Lindner <lindner_marek@yahoo.de>
Cc: tklauser@distanz.ch, b.a.t.m.a.n@lists.open-mesh.org,
	siwu@hrz.tu-chemnitz.de
Subject: Re: [B.A.T.M.A.N.] patch "staging: batman-adv: Use linux/etherdevice.h address	helper functions" added to staging tree
Date: Wed, 10 Nov 2010 08:04:55 -0800	[thread overview]
Message-ID: <20101110160455.GC10561@suse.de> (raw)
In-Reply-To: <201011101117.03979.lindner_marek@yahoo.de>

On Wed, Nov 10, 2010 at 11:17:03AM +0100, Marek Lindner wrote:
> 
> Greg,
> 
> > The patch is only compile-tested.
> 
> [..]
> 
> > diff --git a/drivers/staging/batman-adv/main.c
> > b/drivers/staging/batman-adv/main.c index 0587940..6ea6420 100644
> > --- a/drivers/staging/batman-adv/main.c
> > +++ b/drivers/staging/batman-adv/main.c
> > @@ -149,7 +149,7 @@ void dec_module_count(void)
> > 
> >  int compare_orig(void *data1, void *data2)
> >  {
> > -	return (memcmp(data1, data2, ETH_ALEN) == 0 ? 1 : 0);
> > +	return (compare_ether_addr(data1, data2) == 0 ? 1 : 0);
> >  }
> 
> I'm wondering why you accepted this patch despite the raised objections 
> regarding alignment problems. [1][2]

Because at the end of that thread, it sounded like you all agreed that
this patch was acceptable.

If not, then please let me know and I will revert it.

thanks,

greg k-h

  reply	other threads:[~2010-11-10 16:04 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <12893476522148@site>
2010-11-10 10:17 ` [B.A.T.M.A.N.] patch "staging: batman-adv: Use linux/etherdevice.h address helper functions" added to staging tree Marek Lindner
2010-11-10 16:04   ` Greg KH [this message]
2010-11-10 16:46     ` Sven Eckelmann
2010-11-11  1:11       ` Greg KH
2010-11-11 10:34         ` Marek Lindner
2010-11-11  8:52       ` Tobias Klauser
     [not found]         ` <BAY127-W15AD53BC245C1D430CF07BCF360@phx.gbl>
2010-11-15 10:21           ` Marek Lindner
2010-11-17 16:32         ` Marek Lindner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20101110160455.GC10561@suse.de \
    --to=gregkh@suse.de \
    --cc=b.a.t.m.a.n@lists.open-mesh.org \
    --cc=lindner_marek@yahoo.de \
    --cc=siwu@hrz.tu-chemnitz.de \
    --cc=tklauser@distanz.ch \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox