public inbox for b.a.t.m.a.n@lists.open-mesh.org
 help / color / mirror / Atom feed
From: Marek Lindner <lindner_marek@yahoo.de>
To: The list for a Better Approach To Mobile Ad-hoc Networking
	<b.a.t.m.a.n@lists.open-mesh.org>
Subject: Re: [B.A.T.M.A.N.] [PATCH] batman-adv: Ensure that eth_type_trans gets linear memory
Date: Mon, 22 Nov 2010 00:07:28 +0100	[thread overview]
Message-ID: <201011220007.30358.lindner_marek@yahoo.de> (raw)
In-Reply-To: <1290349981-23883-1-git-send-email-sven.eckelmann@gmx.de>

On Sunday 21 November 2010 15:33:01 Sven Eckelmann wrote:
> eth_type_trans tries to pull data with the length of the ethernet header
> from the skb. We only ensured that enough data for the first ethernet
> header and the batman header is available in non-paged memory of the skb
> and not for the ethernet after the batman header.
> 
> eth_type_trans would fail sometimes with drivers which don't ensure that
> all there data is perfectly linearised.

Ok, I went ahead and applied this patch in revision 1874 after some 
discussion. No Intel user needs to suffer if we can avoid it.  ;-)

Thanks,
Marek

      reply	other threads:[~2010-11-21 23:07 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-11-21 13:32 [B.A.T.M.A.N.] batman-adv crash on Intel 3945ABG & 4965 AGN Marek Lindner
2010-11-21 14:33 ` [B.A.T.M.A.N.] [PATCH] batman-adv: Ensure that eth_type_trans gets linear memory Sven Eckelmann
2010-11-21 23:07   ` Marek Lindner [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201011220007.30358.lindner_marek@yahoo.de \
    --to=lindner_marek@yahoo.de \
    --cc=b.a.t.m.a.n@lists.open-mesh.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox