From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <lindner_marek@yahoo.de>
From: Marek Lindner <lindner_marek@yahoo.de>
Date: Wed, 1 Dec 2010 20:48:46 +0100
References: <201012011954.20275.sven.eckelmann@gmx.de>
	<201012012004.34356.sven.eckelmann@gmx.de>
	<20101201.111205.28818479.davem@davemloft.net>
In-Reply-To: <20101201.111205.28818479.davem@davemloft.net>
MIME-Version: 1.0
Content-Type: Text/Plain;
  charset="iso-8859-1"
Content-Transfer-Encoding: 7bit
Message-Id: <201012012048.47096.lindner_marek@yahoo.de>
Subject: Re: [B.A.T.M.A.N.] [PATCHv6] net: Add batman-adv meshing protocol
Reply-To: The list for a Better Approach To Mobile Ad-hoc Networking
	<b.a.t.m.a.n@lists.open-mesh.org>
List-Id: The list for a Better Approach To Mobile Ad-hoc Networking
	<b.a.t.m.a.n.lists.open-mesh.org>
List-Unsubscribe: <https://lists.open-mesh.org/mm/options/b.a.t.m.a.n>,
	<mailto:b.a.t.m.a.n-request@lists.open-mesh.org?subject=unsubscribe>
List-Archive: <http://lists.open-mesh.org/pipermail/b.a.t.m.a.n>
List-Post: <mailto:b.a.t.m.a.n@lists.open-mesh.org>
List-Help: <mailto:b.a.t.m.a.n-request@lists.open-mesh.org?subject=help>
List-Subscribe: <https://lists.open-mesh.org/mm/listinfo/b.a.t.m.a.n>,
	<mailto:b.a.t.m.a.n-request@lists.open-mesh.org?subject=subscribe>
To: b.a.t.m.a.n@lists.open-mesh.org
Cc: netdev@vger.kernel.org, David Miller <davem@davemloft.net>


David,

> Ok, fair enough.

I'm not so sure how to read this - could you please explain ?
We are very thankful regarding any advice how to improve our code and have 
followed every single hint to change the code accordingly (including the hash 
implementation). 
You named the bit operations - we will look into this. What else do you see ? 
Could you be more specific than vaguely saying "the code is full of duplicated 
functionality" ? Have our hash code changes met your expectations ?

Thanks,
Marek