From: Sven Eckelmann <sven.eckelmann@gmx.de>
To: b.a.t.m.a.n@lists.open-mesh.org
Cc: Marek Lindner <lindner_marek@yahoo.de>
Subject: Re: [B.A.T.M.A.N.] performance patches (v2)
Date: Sat, 4 Dec 2010 20:42:14 +0100 [thread overview]
Message-ID: <201012042042.16056.sven.eckelmann@gmx.de> (raw)
In-Reply-To: <201011291800.02971.lindner_marek@yahoo.de>
[-- Attachment #1: Type: Text/Plain, Size: 1793 bytes --]
Marek Lindner wrote:
> Hi,
>
> I continued improving the the performance patches which results in the
> first usable version. I tested it in a VM environment as well as on real
> hardware and did not encounter problematic behavior anymore.
I looked through your patches and have some small suggestions. First I would
like to move the hashtable-functions related patches to the front. This would
make it possible to send a new version of batman-adv to David S. Miller
without adding to many changes (so maybe he doesn't get too angry this time).
Then you missed hashtable_t::elements of the hash implementation which are
only needed for the resize implementation (now it is only a wom :) ). The
hash_iterate function is also still there.... I would like to remove it
completely. hash_remove only rcu locked the list - but we must spinlock here
to prevent double frees. kref_put of data directly after call_rcu for bucket
could lead to invalid memory access when a rcu protected region still accesses
the bucket which isn't removed yet (but the data in the bucket was already
removed). Unneeded(?) hlist_empty checks. Missing conversation of neigh_node
hlist operations to _rcu. Missing rcu_read_unlock's. Missing correct refcnt
for neigh_list
I would rework some of those parts and resend all patches again to the mailing
list. This doesn't mean that I have checked everything.... some of the patches
were just too "wirr" and this is a first try to get it in the right direction.
It still needs a lot of cleanup and testing. For example neigh_list stuff and
the kref_put after call_rcu is complete unfixed and I also didn't finish the
complete patchset.... maybe will continue with it when the patchset is cleaned
up.
Best regards,
Sven
[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2010-12-04 19:42 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-29 17:00 [B.A.T.M.A.N.] performance patches (v2) Marek Lindner
2010-11-29 17:00 ` [B.A.T.M.A.N.] [PATCH 1/9] batman-adv: protect neighbor nodes with reference counters Marek Lindner
2010-11-29 17:00 ` [B.A.T.M.A.N.] [PATCH 2/9] batman-adv: convert neighbor list to hlist Marek Lindner
2010-11-29 17:00 ` [B.A.T.M.A.N.] [PATCH 3/9] batman-adv: protect neighbor list with rcu locks Marek Lindner
2010-11-29 17:00 ` [B.A.T.M.A.N.] [PATCH 4/9] batman-adv: remove hash resize functions Marek Lindner
2010-11-29 17:00 ` [B.A.T.M.A.N.] [PATCH 5/9] batman-adv: protect each hash row with rcu locks Marek Lindner
2010-11-29 17:00 ` [B.A.T.M.A.N.] [PATCH 6/9] batman-adv: protect originator nodes with reference counters Marek Lindner
2010-11-29 17:00 ` [B.A.T.M.A.N.] [PATCH 7/9] batman-adv: replace orig_hash hash_iterate() with individual functions Marek Lindner
2010-11-29 17:00 ` [B.A.T.M.A.N.] [PATCH 8/9] batman-adv: protect ogm counter arrays with spinlock Marek Lindner
2010-11-29 17:00 ` [B.A.T.M.A.N.] [PATCH 9/9] batman-adv: remove orig_hash spinlock Marek Lindner
2010-12-04 19:42 ` Sven Eckelmann [this message]
2010-12-04 20:03 ` [B.A.T.M.A.N.] [PATCH 1/9] batman-adv: remove hash resize functions Sven Eckelmann
2010-12-12 20:32 ` Marek Lindner
2010-12-04 20:03 ` [B.A.T.M.A.N.] [PATCH 2/9] batman-adv: Remove hash_iterate Sven Eckelmann
2010-12-12 20:33 ` Marek Lindner
2010-12-04 20:03 ` [B.A.T.M.A.N.] [PATCH 3/9] batman-adv: protect neighbor nodes with reference counters Sven Eckelmann
2010-12-12 21:55 ` Marek Lindner
2010-12-04 20:03 ` [B.A.T.M.A.N.] [PATCH 4/9] batman-adv: convert neighbor list to hlist Sven Eckelmann
2010-12-12 21:56 ` Marek Lindner
2010-12-04 20:03 ` [B.A.T.M.A.N.] [PATCH 5/9] batman-adv: protect neighbor list with rcu locks Sven Eckelmann
2010-12-12 21:57 ` Marek Lindner
2010-12-04 20:03 ` [B.A.T.M.A.N.] [PATCH 6/9] batman-adv: protect each hash row " Sven Eckelmann
2010-12-04 20:03 ` [B.A.T.M.A.N.] [PATCH 7/9] batman-adv: protect originator nodes with reference counters Sven Eckelmann
2010-12-04 20:03 ` [B.A.T.M.A.N.] [PATCH 8/9] batman-adv: protect ogm counter arrays with spinlock Sven Eckelmann
2010-12-04 20:03 ` [B.A.T.M.A.N.] [PATCH 9/9] batman-adv: remove orig_hash spinlock Sven Eckelmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201012042042.16056.sven.eckelmann@gmx.de \
--to=sven.eckelmann@gmx.de \
--cc=b.a.t.m.a.n@lists.open-mesh.org \
--cc=lindner_marek@yahoo.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox