[B.A.T.M.A.N.] [PATCH] batman-adv: Modifing hna_local_fill_buffer() return value

[B.A.T.M.A.N.] [PATCH] batman-adv: Modifing hna_local_fill_buffer() return value

[Antonio Quartulli]

After changeset 1888, the return value of hna_local_fill_buffer() has
not been changed to _count_. In this way an eroneous num_hna was
calculated before sending the new OGM packet.

Signed-off-by: Antonio Quartulli <ordex@ritirata.org>
---
 translation-table.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/translation-table.c b/translation-table.c
index a19e16c..a633b5a 100644
--- a/translation-table.c
+++ b/translation-table.c
@@ -162,7 +162,7 @@ int hna_local_fill_buffer(struct bat_priv *bat_priv,
                atomic_set(&bat_priv->hna_local_changed, 0);
 
        spin_unlock_bh(&bat_priv->hna_lhash_lock);
-       return i;
+       return count;
 }
 
 int hna_local_seq_print_text(struct seq_file *seq, void *offset)


-- 
Antonio Quartulli

..each of us alone is worth nothing..
Ernesto "Che" Guevara

Re: [B.A.T.M.A.N.] [PATCH] batman-adv: Modifing hna_local_fill_buffer() return value

[Sven Eckelmann]

[-- Attachment #1: Type: Text/Plain, Size: 1289 bytes --]

Antonio Quartulli wrote:
> After changeset 1888, the return value of hna_local_fill_buffer() has
> not been changed to _count_. In this way an eroneous num_hna was
> calculated before sending the new OGM packet.
> 
> Signed-off-by: Antonio Quartulli <ordex@ritirata.org>
> ---
>  translation-table.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/translation-table.c b/translation-table.c
> index a19e16c..a633b5a 100644
> --- a/translation-table.c
> +++ b/translation-table.c
> @@ -162,7 +162,7 @@ int hna_local_fill_buffer(struct bat_priv *bat_priv,
>                 atomic_set(&bat_priv->hna_local_changed, 0);
> 
>         spin_unlock_bh(&bat_priv->hna_lhash_lock);
> -       return i;
> +       return count;
>  }
> 
>  int hna_local_seq_print_text(struct seq_file *seq, void *offset)

Your mail program mangled the patch. Please use git-send-mail or check how to 
fix your mailing program (see for example Documentation/email-clients.txt 
inside the linux tree).

Also correct your DNS entries for DKIM (you seem to sign your mails with it) - 
they aren't available and every DKIM aware receiving server will not accept 
the mails without adsp._domainkey. and mail._domainkey. TXT DNS entries.

Best regards,
	Sven

[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

[B.A.T.M.A.N.] [PATCH] batman-adv: Modifing hna_local_fill_buffer() return value

[Antonio Quartulli]

After changeset 1888, the return value of hna_local_fill_buffer() has
not been changed to _count_. In this way an eroneous num_hna was
calculated before sending the new OGM packet.

[B.A.T.M.A.N.] [PATCH] batman-adv: Modifing hna_local_fill_buffer() return value

[Antonio Quartulli]

 After changeset 1888, the return value of hna_local_fill_buffer() has
 not been changed to _count_. In this way an eroneous num_hna was
 calculated before sending the new OGM packet.

---
 translation-table.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/translation-table.c b/translation-table.c
index a19e16c..a633b5a 100644
--- a/translation-table.c
+++ b/translation-table.c
@@ -162,7 +162,7 @@ int hna_local_fill_buffer(struct bat_priv *bat_priv,
 		atomic_set(&bat_priv->hna_local_changed, 0);
 
 	spin_unlock_bh(&bat_priv->hna_lhash_lock);
-	return i;
+	return count;
 }
 
 int hna_local_seq_print_text(struct seq_file *seq, void *offset)
-- 
1.7.2.2

Re: [B.A.T.M.A.N.] [PATCH] batman-adv: Modifing hna_local_fill_buffer() return value

[Marek Lindner]

On Tuesday 21 December 2010 03:03:09 Antonio Quartulli wrote:
>  After changeset 1888, the return value of hna_local_fill_buffer() has
>  not been changed to _count_. In this way an eroneous num_hna was
>  calculated before sending the new OGM packe

Thanks for resending the patch - applied in revision 1898.

Good catch,
Marek