From: Marek Lindner <lindner_marek@yahoo.de>
To: The list for a Better Approach To Mobile Ad-hoc Networking
<b.a.t.m.a.n@lists.open-mesh.org>
Subject: Re: [B.A.T.M.A.N.] [PATCH] batctl: add raw wifi packet decapsulation support
Date: Thu, 27 Jan 2011 13:37:57 +0100 [thread overview]
Message-ID: <201101271337.58236.lindner_marek@yahoo.de> (raw)
In-Reply-To: <201101261602.38873.sven@narfation.org>
On Wednesday 26 January 2011 16:02:32 Sven Eckelmann wrote:
> Didn't we say yesterday that we must either use ntohs or only read the
> first byte of the framecontrol? The last option which comes to my mind is
> to define IEEE80211_FCTL_FTYPE and IEEE80211_FTYPE_DATA for big and little
> endian independently.
I must have misunderstood something but you are right - I'm going to change it
and publish a second patch.
> > + if (fc & IEEE80211_STYPE_QOS_DATA)
> > + hdr_len += 2;
>
> Here are you testing only on bit. Are you sure that the other 3 bits aren't
> interesting? At least one combination isn't well defined by the 802.11
> standard from 2007 and some others are null data types.
I'd claim we only care if it is QoS or not because all QoS packets have a
longer header (QoS control field).
The spec says: "bit 7 is set to 1 in the QoS data subtypes, which have QoS
Control fields in their MAC headers"
Regards,
Marek
next prev parent reply other threads:[~2011-01-27 12:37 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-26 14:30 [B.A.T.M.A.N.] [PATCH] batctl: add raw wifi packet decapsulation support Marek Lindner
2011-01-26 15:02 ` Sven Eckelmann
2011-01-27 12:37 ` Marek Lindner [this message]
2011-01-26 15:41 ` Andrew Lunn
2011-01-27 12:27 ` Marek Lindner
2011-01-28 17:24 ` Andrew Lunn
2011-01-28 20:14 ` Marek Lindner
2011-01-29 16:16 ` [B.A.T.M.A.N.] [PATCHv2] " Marek Lindner
2011-02-01 22:08 ` Marek Lindner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201101271337.58236.lindner_marek@yahoo.de \
--to=lindner_marek@yahoo.de \
--cc=b.a.t.m.a.n@lists.open-mesh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox