From: Marek Lindner <lindner_marek@yahoo.de>
To: The list for a Better Approach To Mobile Ad-hoc Networking
<b.a.t.m.a.n@lists.open-mesh.org>
Subject: Re: [B.A.T.M.A.N.] [PATCH] batctl: add raw wifi packet decapsulation support
Date: Fri, 28 Jan 2011 21:14:33 +0100 [thread overview]
Message-ID: <201101282114.34758.lindner_marek@yahoo.de> (raw)
In-Reply-To: <20110128172416.GW23716@lunn.ch>
On Friday 28 January 2011 18:24:16 Andrew Lunn wrote:
> So i was expecting to see something like DSTODS. However the madwifi
> macros are for the complete DIR field, where as you are looking at
> individual bits. So
>
> (fc & IEEE80211_FCTL_FROMDS) && (fc & IEEE80211_FCTL_TODS)
>
> is equivalent to the madwifi IEEE80211_FC1_DIR_DSTODS.
>
> So you header length calculation looks O.K.
I rather discuss potential bugs even if they turn out not to be bugs instead
of letting them through. :)
Thanks for your review,
Marek
next prev parent reply other threads:[~2011-01-28 20:14 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-26 14:30 [B.A.T.M.A.N.] [PATCH] batctl: add raw wifi packet decapsulation support Marek Lindner
2011-01-26 15:02 ` Sven Eckelmann
2011-01-27 12:37 ` Marek Lindner
2011-01-26 15:41 ` Andrew Lunn
2011-01-27 12:27 ` Marek Lindner
2011-01-28 17:24 ` Andrew Lunn
2011-01-28 20:14 ` Marek Lindner [this message]
2011-01-29 16:16 ` [B.A.T.M.A.N.] [PATCHv2] " Marek Lindner
2011-02-01 22:08 ` Marek Lindner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201101282114.34758.lindner_marek@yahoo.de \
--to=lindner_marek@yahoo.de \
--cc=b.a.t.m.a.n@lists.open-mesh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox