* [B.A.T.M.A.N.] [PATCH] batctl: avoid error message when command was successful
@ 2011-04-13 15:27 Marek Lindner
2011-04-16 8:04 ` Sven Eckelmann
2011-04-17 16:22 ` Simon Wunderlich
0 siblings, 2 replies; 3+ messages in thread
From: Marek Lindner @ 2011-04-13 15:27 UTC (permalink / raw)
To: b.a.t.m.a.n; +Cc: Marek Lindner
Reported-by: Linus Lüssing <linus.luessing@web.de>
Signed-off-by: Marek Lindner <lindner_marek@yahoo.de>
---
sys.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/sys.c b/sys.c
index 729f898..3511b40 100644
--- a/sys.c
+++ b/sys.c
@@ -420,10 +420,10 @@ int handle_gw_setting(char *mesh_iface, int argc, char **argv)
case GW_MODE_SERVER:
res = write_file(path_buff, SYS_GW_BW, argv[2], NULL);
break;
- default:
- goto out;
}
+ goto out;
+
opt_err:
printf("Error - the supplied argument is invalid: %s\n", argv[1]);
printf("The following values are allowed:\n");
--
1.7.2.3
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [B.A.T.M.A.N.] [PATCH] batctl: avoid error message when command was successful
2011-04-13 15:27 [B.A.T.M.A.N.] [PATCH] batctl: avoid error message when command was successful Marek Lindner
@ 2011-04-16 8:04 ` Sven Eckelmann
2011-04-17 16:22 ` Simon Wunderlich
1 sibling, 0 replies; 3+ messages in thread
From: Sven Eckelmann @ 2011-04-16 8:04 UTC (permalink / raw)
To: b.a.t.m.a.n; +Cc: Marek Lindner
[-- Attachment #1: Type: Text/Plain, Size: 182 bytes --]
Marek Lindner wrote:
> Reported-by: Linus Lüssing <linus.luessing@web.de>
> Signed-off-by: Marek Lindner <lindner_marek@yahoo.de>
Acked-by: Sven Eckelmann <sven@narfation.org>
[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [B.A.T.M.A.N.] [PATCH] batctl: avoid error message when command was successful
2011-04-13 15:27 [B.A.T.M.A.N.] [PATCH] batctl: avoid error message when command was successful Marek Lindner
2011-04-16 8:04 ` Sven Eckelmann
@ 2011-04-17 16:22 ` Simon Wunderlich
1 sibling, 0 replies; 3+ messages in thread
From: Simon Wunderlich @ 2011-04-17 16:22 UTC (permalink / raw)
To: The list for a Better Approach To Mobile Ad-hoc Networking
[-- Attachment #1: Type: text/plain, Size: 809 bytes --]
Applied in eee3fc6,
thanks
Simon
On Wed, Apr 13, 2011 at 05:27:00PM +0200, Marek Lindner wrote:
> Reported-by: Linus Lüssing <linus.luessing@web.de>
> Signed-off-by: Marek Lindner <lindner_marek@yahoo.de>
> ---
> sys.c | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/sys.c b/sys.c
> index 729f898..3511b40 100644
> --- a/sys.c
> +++ b/sys.c
> @@ -420,10 +420,10 @@ int handle_gw_setting(char *mesh_iface, int argc, char **argv)
> case GW_MODE_SERVER:
> res = write_file(path_buff, SYS_GW_BW, argv[2], NULL);
> break;
> - default:
> - goto out;
> }
>
> + goto out;
> +
> opt_err:
> printf("Error - the supplied argument is invalid: %s\n", argv[1]);
> printf("The following values are allowed:\n");
> --
> 1.7.2.3
>
>
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 198 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2011-04-17 16:22 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-04-13 15:27 [B.A.T.M.A.N.] [PATCH] batctl: avoid error message when command was successful Marek Lindner
2011-04-16 8:04 ` Sven Eckelmann
2011-04-17 16:22 ` Simon Wunderlich
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox