Re: [B.A.T.M.A.N.] [PATCHv4 1/3] batman-adv: improved client announcement mechanism

Sven Eckelmann
2011-05-17T19:09:35Z

[-- Attachment #1: Type: Text/Plain, Size: 749 bytes --]

Nack

There are two many small things that need to be changed. I didn't to a
complete review, but at least the primary_if dereference is unacceptable.

From IRC:

<ecsv_> could you do me the favour and go through my cleanup patches and also fix your code... it is too much to send every problem
to the list
<ecsv_> and the kfree_rcu patches will be merged soon in linux mainline... so please prepare your patches for that
<ecsv_> and why is there still an align in batman_packet - this doesn't make any sense
<ecsv_> and we already have functionality to do the before-after check of the ttvn
<ecsv_> and you try to dereference primary_if (without using primary_if_get_selected) directly... this is not allowed

Kind regards,
Sven

[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 836 bytes --]