Re: [B.A.T.M.A.N.] [PATCH 2/4] batman-adv: improved client announcement mechanismy

Antonio Quartulli
2011-05-03T17:07:11Z

On Tue, May 03, 2011 at 05:56:45PM +0200, Marek Lindner wrote:
> On Tuesday 03 May 2011 17:50:07 Antonio Quartulli wrote:
> > > I think this is the information bisect uses to look for routing loops
> > > etc. Do you plan to extend bisect to look for TT problems? Does it
> > > make sense to add a new DBG_TT which dumps the adds and removes in the
> > > OGM?
> > >
> > >
> >
> > I don't think we really need a new log "channel". Till now all the hna
> > operations were printed on DBG_ROUTE, so I think we could continue using
> > it..
>
> Actually, I liked Andrew's suggestion. So far the HNA handling did not have
> its own debug "channel" because it was plain simple - nothing much to debug
> there. The advanced handling we are going to add might require debugging in
> the future ...
>
> Even if you don't plan to extend bisect at the moment, extra TT debug info
> would make it easier to add it later on. I'd be surprised if the current
> concept / code "just works". Bugs tend to hide in unexpected places. ;-)
>

Definitely :)

At this point I think it is better to introduce this new log "channel":
BAT_TT. I'll redirect all the TT related messages to this new channel.

Thank you

Regards,

--
Antonio Quartulli

..each of us alone is worth nothing..
Ernesto "Che" Guevara