From: Marek Lindner <lindner_marek@yahoo.de>
To: The list for a Better Approach To Mobile Ad-hoc Networking
<b.a.t.m.a.n@lists.open-mesh.org>
Subject: Re: [B.A.T.M.A.N.] [PATCH] batman-adv: move neigh_node->if_incoming->if_status check in find_router()
Date: Thu, 5 May 2011 14:20:10 +0200 [thread overview]
Message-ID: <201105051420.10634.lindner_marek@yahoo.de> (raw)
In-Reply-To: <1304583702-23969-1-git-send-email-ordex@autistici.org>
On Thursday 05 May 2011 10:21:42 Antonio Quartulli wrote:
> return_router:
> + if (router && router->if_incoming->if_status != IF_ACTIVE)
> + router = NULL;
> +
> rcu_read_unlock();
> return router;
You are breaking the reference counting of 'router' here. While looking at
your patch I found another refcount imbalance. Check the patch I just posted
(Fix refcount imbalance in find_router).
Regards,
Marek
next prev parent reply other threads:[~2011-05-05 12:20 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-05 8:21 [B.A.T.M.A.N.] [PATCH] batman-adv: move neigh_node->if_incoming->if_status check in find_router() Antonio Quartulli
2011-05-05 12:20 ` Marek Lindner [this message]
2011-05-08 18:44 ` Antonio Quartulli
2011-05-08 18:52 ` [B.A.T.M.A.N.] [PATCHv2] " Antonio Quartulli
2011-05-09 11:27 ` Marek Lindner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201105051420.10634.lindner_marek@yahoo.de \
--to=lindner_marek@yahoo.de \
--cc=b.a.t.m.a.n@lists.open-mesh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox