From: Sven Eckelmann <sven@narfation.org>
To: b.a.t.m.a.n@lists.open-mesh.org
Subject: Re: [B.A.T.M.A.N.] [PATCH 1/9] batman-adv: Annotate functions with format strings
Date: Sun, 15 May 2011 09:27:57 +0200 [thread overview]
Message-ID: <201105150927.59225.sven@narfation.org> (raw)
In-Reply-To: <20110515063624.GK4071@lunn.ch>
[-- Attachment #1: Type: Text/Plain, Size: 610 bytes --]
Andrew Lunn wrote:
> Nice set of patches.
>
> Are you using any tools to find these issues? I don't think sparse
> points these out.
I read the linux kernel mailinglist and found a mail where batman-ad was
mentioned [1] - nothing to be proud of. So I started to look around and found
something here and there... at the end I had bleeding eyes and 9 patches (yes,
there are ten because I did a break and noticed too late that I wanted to add
the sparse/lockdep annotation for the RCU update-side since a while).
Kind regards,
Sven
[1] http://thread.gmane.org/gmane.linux.kernel/1139857
[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2011-05-15 7:27 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-14 21:14 [B.A.T.M.A.N.] [PATCH 1/9] batman-adv: Annotate functions with format strings Sven Eckelmann
2011-05-14 21:14 ` [B.A.T.M.A.N.] [PATCH 2/9] batman-adv: Print jiffies as unsigned long Sven Eckelmann
2011-05-18 9:35 ` Marek Lindner
2011-05-14 21:14 ` [B.A.T.M.A.N.] [PATCH 3/9] batman-adv: Remove comparising < 0 for unsigned type Sven Eckelmann
2011-05-18 9:37 ` Marek Lindner
2011-05-14 21:14 ` [B.A.T.M.A.N.] [PATCH 4/9] batman-adv: Don't do pointer arithmetic with void* Sven Eckelmann
2011-05-18 9:40 ` Marek Lindner
2011-05-14 21:14 ` [B.A.T.M.A.N.] [PATCH 5/9] batman-adv: Add const type qualifier for pointers Sven Eckelmann
2011-05-18 10:10 ` Marek Lindner
2011-05-14 21:14 ` [B.A.T.M.A.N.] [PATCH 6/9] batman-adv: Only use in up and down gw representation Sven Eckelmann
2011-05-18 10:24 ` Marek Lindner
2011-05-14 21:14 ` [B.A.T.M.A.N.] [PATCH 7/9] batman-adv: Remove explicit casts cast from void* for store Sven Eckelmann
2011-05-19 7:22 ` Marek Lindner
2011-05-14 21:14 ` [B.A.T.M.A.N.] [PATCH 8/9] batman-adv: Remove casts from type x to type x Sven Eckelmann
2011-05-19 7:26 ` Marek Lindner
2011-05-14 21:14 ` [B.A.T.M.A.N.] [PATCH 9/9] batman-adv: Calculate sizeof using variable insead of types Sven Eckelmann
2011-05-19 8:07 ` Marek Lindner
2011-05-14 22:50 ` [B.A.T.M.A.N.] [PATCH 10/09] batman-adv: Use rcu_dereference_protected by update-side Sven Eckelmann
2011-05-19 8:12 ` Marek Lindner
2011-05-15 6:36 ` [B.A.T.M.A.N.] [PATCH 1/9] batman-adv: Annotate functions with format strings Andrew Lunn
2011-05-15 7:27 ` Sven Eckelmann [this message]
2011-05-19 8:28 ` Marek Lindner
2011-05-18 9:32 ` Marek Lindner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201105150927.59225.sven@narfation.org \
--to=sven@narfation.org \
--cc=b.a.t.m.a.n@lists.open-mesh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox