From: Sven Eckelmann <sven@narfation.org>
To: b.a.t.m.a.n@lists.open-mesh.org
Subject: Re: [B.A.T.M.A.N.] [PATCH] batman-adv: a multiline comment should precede the variable it is describing
Date: Thu, 19 May 2011 21:40:55 +0200 [thread overview]
Message-ID: <201105192141.11078.sven@narfation.org> (raw)
In-Reply-To: <1305730043-3666-1-git-send-email-ordex@autistici.org>
[-- Attachment #1: Type: Text/Plain, Size: 976 bytes --]
Antonio Quartulli wrote:
> This comment has been wrongly put after the variable it refers to and was
> also bad indented
>
> Signed-off-by: Antonio Quartulli <ordex@autistici.org>
> ---
>
> types.h | 8 ++++----
> 1 files changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/types.h b/types.h
> index fab70e8..65b3222 100644
> --- a/types.h
> +++ b/types.h
> @@ -246,10 +246,10 @@ struct frag_packet_list_entry {
> };
>
> struct vis_info {
> - unsigned long first_seen;
> - struct list_head recv_list;
> - /* list of server-neighbors we received a vis-packet
> - * from. we should not reply to them. */
> + unsigned long first_seen;
> + /* list of server-neighbors we received a vis-packet
> + * from. we should not reply to them. */
> + struct list_head recv_list;
> struct list_head send_list;
> struct kref refcount;
> struct hlist_node hash_entry;
Acked-by: Sven Eckelmann <sven@narfation.org>
[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2011-05-19 19:40 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-18 14:47 [B.A.T.M.A.N.] [PATCH] batman-adv: a multiline comment should precede the variable it is describing Antonio Quartulli
2011-05-19 19:40 ` Sven Eckelmann [this message]
2011-05-22 9:20 ` Marek Lindner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201105192141.11078.sven@narfation.org \
--to=sven@narfation.org \
--cc=b.a.t.m.a.n@lists.open-mesh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox