Re: [B.A.T.M.A.N.] [PATCH 2/4] batman-adv: improved client announcement mechanism

Gioacchino Mazzurco
2011-04-28T17:46:25Z

>In my opinion it would not be so bad to include this dependency as the
>crc16 module provides this function only and no more.

+1

2011/4/28 Antonio Quartulli <ordex@autistici.org>:
> On Thu, Apr 28, 2011 at 07:34:29PM +0200, Marek Lindner wrote:
>> On Thursday 28 April 2011 18:10:31 Andrew Lunn wrote:
>> > Shouldn't this dependency be listed in the Kconfig file? I think you
>> > need to add
>> >
>> > select CRC16
>>
>> Actually, the question is whether it is a wise move to introduce this
>> dependency just for that function or whether somebody has an idea how to avoid
>> it. Obviously, copying this function into our module won't be accepted by the
>> kernel developers.
>>
>
> In my opinion it would not be so bad to include this dependency as the
> crc16 module provides this function only and no more.
> By the way any idea is welcome!
>
> --
> Antonio Quartulli
>
> ..each of us alone is worth nothing..
> Ernesto "Che" Guevara
>