Re: [B.A.T.M.A.N.] [PATCHv2 2/3] batman-adv: improved roaming mechanism

Sven Eckelmann
2011-05-22T11:44:56Z

[-- Attachment #1: Type: Text/Plain, Size: 334 bytes --]

Antonio Quartulli wrote:
> + memcpy(roam_adv_packet->src,
> + bat_priv->primary_if->net_dev->dev_addr, ETH_ALEN);

Again, Nack.

This is _definitely_ not allowed. Please use the primary_if != NULL that you
got through primary_if_get_selected instead of dereferencing
bat_priv->primary_if directly.

Kind regards,
Sven

[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 836 bytes --]