Re: [B.A.T.M.A.N.] [PATCH 2/4] batman-adv: improved client announcement mechanismy

Antonio Quartulli
2011-05-03T15:50:07Z

On sab, apr 30, 2011 at 10:42:26 +0200, Andrew Lunn wrote:
> > bat_dbg(DBG_BATMAN, bat_priv,
> > "Received BATMAN packet via NB: %pM, IF: %s [%pM] "
> > - "(from OG: %pM, via prev OG: %pM, seqno %d, tq %d, "
> > - "TTL %d, V %d, IDF %d)\n",
> > + "(from OG: %pM, via prev OG: %pM, seqno %d, ttvn %u, "
> > + "crc %u, changes %u, td %d, TTL %d, V %d, IDF %d)\n",
> > ethhdr->h_source, if_incoming->net_dev->name,
> > if_incoming->net_dev->dev_addr, batman_packet->orig,
> > batman_packet->prev_sender, batman_packet->seqno,
> > - batman_packet->tq, batman_packet->ttl, batman_packet->version,
> > + batman_packet->tt_ver_num, batman_packet->tt_crc,
> > + batman_packet->tt_num_changes, batman_packet->tq,
> > + batman_packet->ttl, batman_packet->version,
> > has_directlink_flag);
>
> I think this is the information bisect uses to look for routing loops
> etc. Do you plan to extend bisect to look for TT problems? Does it
> make sense to add a new DBG_TT which dumps the adds and removes in the
> OGM?
>

I don't think we really need a new log "channel". Till now all the hna
operations were printed on DBG_ROUTE, so I think we could continue using
it..

The bisect TT extension is not currently planned, but at least it is now
supported :)

Regards,

--
Antonio Quartulli

..each of us alone is worth nothing..
Ernesto "Che" Guevara