Re: [B.A.T.M.A.N.] [PATCH-marek] batman-adv: Unify the first 3 bytes in each packet

Sven Eckelmann
2011-05-28T12:43:29Z

[-- Attachment #1: Type: Text/Plain, Size: 942 bytes --]

On Saturday 28 May 2011 14:17:14 Marek Lindner wrote:
> On Saturday 28 May 2011 14:07:10 Sven Eckelmann wrote:
> > Why dont you use the reserverd part for the flags which are currently not
> > in unicast? Then you could also remove that other align byte. It would
> > still be possible to add flags to unicast packets when necessary.
>
> The unicast_frag header assumes it looks like the unicast header plus some
> extra fields:

Where does it assume that the frag is _not_ part of the unicast_packet header?

>
> struct unicast_frag_packet {
> struct unicast_packet unicast_packet;
> uint8_t flags;
> uint8_t align;
> uint8_t orig[6];
> uint16_t seqno;
> };
>
> We probably should add a little comment there to make that clear.
>
> Both reserved fields (unicast + unicast frag) are going to be converted to
> ttvn with the tt patches.

Ok, makes sense to use reserve fields then

Kind regards,
Sven

[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 836 bytes --]