From: Sven Eckelmann <sven@narfation.org>
To: Antonio Quartulli <ordex@autistici.org>
Cc: b.a.t.m.a.n@lists.open-mesh.org
Subject: [B.A.T.M.A.N.] Combination of flags in tt_query packets
Date: Sun, 12 Jun 2011 11:52:00 +0200 [thread overview]
Message-ID: <201106121152.02177.sven@narfation.org> (raw)
[-- Attachment #1: Type: Text/Plain, Size: 917 bytes --]
Hi,
just looked a little bit closer at your tt_query implementation and was
reminded that we had a small discussion in IRC some weeks ago.
<ecsv> can those flags be mixed?
<ordex> mixed? in which way?
<ecsv> request | table -> still a valid package
<ecsv> sry, packet
<ordex> yes it is, because it means "I'm requesting a full table"
<ordex> all the combinations are valid
This sounds wrong when I look at the tt_query packet. There we have a tt_data
field which can used used exclusive by either TT_REQUEST (x)or TT_RESPONSE.
Therefore, it is not possible to use both flags at the same time. Can you
please explain how this is handled or otherwise change it so that only one bit
in flags is used to decide if it is an response or a request.
Maybe this was the result of the discussion with Marek about the roaming stuff
- but i don't think that it applies here.
Kind regards,
Sven
[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next reply other threads:[~2011-06-12 9:52 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-12 9:52 Sven Eckelmann [this message]
2011-06-13 13:25 ` [B.A.T.M.A.N.] Combination of flags in tt_query packets Antonio Quartulli
2011-06-13 14:29 ` Sven Eckelmann
2011-06-13 14:30 ` Sven Eckelmann
2011-06-13 17:02 ` Antonio Quartulli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201106121152.02177.sven@narfation.org \
--to=sven@narfation.org \
--cc=b.a.t.m.a.n@lists.open-mesh.org \
--cc=ordex@autistici.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox