From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: From: Marek Lindner Date: Sun, 12 Jun 2011 12:04:49 +0200 References: <1307869838-25550-1-git-send-email-sven@narfation.org> In-Reply-To: <1307869838-25550-1-git-send-email-sven@narfation.org> MIME-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-15" Content-Transfer-Encoding: 7bit Message-Id: <201106121204.50138.lindner_marek@yahoo.de> Subject: Re: [B.A.T.M.A.N.] [PATCH] batman-adv: Force packed placment of tt_change Reply-To: The list for a Better Approach To Mobile Ad-hoc Networking List-Id: The list for a Better Approach To Mobile Ad-hoc Networking List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: The list for a Better Approach To Mobile Ad-hoc Networking On Sunday, June 12, 2011 11:10:38 AM Sven Eckelmann wrote: > Every data structure which is used to send data over the wire must be > fixed in layout to prevent incompatibility between different > architectures. Those incompatibilities could be generated by extra bytes > between members and at the end of the structure. > > tt_changes_fill_buffer and tt_len use that structure to copy the correct > amount of data from an internal structure to the actual packet. We must > ensure that this packet buffer only has data which can be interpreted by > any architecture Applied in revision 92f4aaa. Thanks, Marek