Re: [B.A.T.M.A.N.] Combination of flags in tt_query packets

Sven Eckelmann
2011-06-13T14:30:51Z

[-- Attachment #1: Type: Text/Plain, Size: 557 bytes --]

Sven Eckelmann wrote:
> Then you say that you don't use flags but 2 bits to store 2 values. Please
> don't use it in your code as flags, but use something like (x &
> TT_TYPE_MASK) to extract the corresponding bits and compare the resulting
> values against representation of TT_RESPONSE and TT_RESPONSE (TT_TYPE_MASK
> would be 0x3, TT_RESPONSE 0 and TT_REQUEST 3). Also remove the TT_RESPONSE
> and TT_REQUEST from the enum tt_query_flags and use another enum for them.

s/TT_REQUEST 3/TT_REQUEST 2/

1 and 3 are currently undefined.