[B.A.T.M.A.N.] Combination of flags in tt_query packets

Sven Eckelmann
2011-06-12T09:52:00Z

[-- Attachment #1: Type: Text/Plain, Size: 917 bytes --]

Hi,

just looked a little bit closer at your tt_query implementation and was
reminded that we had a small discussion in IRC some weeks ago.

<ecsv> can those flags be mixed?
<ordex> mixed? in which way?
<ecsv> request | table -> still a valid package
<ecsv> sry, packet
<ordex> yes it is, because it means "I'm requesting a full table"
<ordex> all the combinations are valid

This sounds wrong when I look at the tt_query packet. There we have a tt_data
field which can used used exclusive by either TT_REQUEST (x)or TT_RESPONSE.
Therefore, it is not possible to use both flags at the same time. Can you
please explain how this is handled or otherwise change it so that only one bit
in flags is used to decide if it is an response or a request.

Maybe this was the result of the discussion with Marek about the roaming stuff
- but i don't think that it applies here.