From: Sven Eckelmann <sven@narfation.org>
To: David Howells <dhowells@redhat.com>
Cc: netdev@vger.kernel.org, b.a.t.m.a.n@lists.open-mesh.org,
Marek Lindner <lindner_marek@yahoo.de>,
Simon Wunderlich <siwu@hrz.tu-chemnitz.de>
Subject: Re: [B.A.T.M.A.N.] [PATCH 1/2] batman-adv: count_real_packets() in batman-adv assumes char is signed
Date: Wed, 15 Jun 2011 07:59:15 +0200 [thread overview]
Message-ID: <201106150759.15643.sven@narfation.org> (raw)
In-Reply-To: <20110614235132.3724.57632.stgit@warthog.procyon.org.uk>
[-- Attachment #1: Type: Text/Plain, Size: 738 bytes --]
David Howells wrote:
> count_real_packets() in batman-adv assumes char is signed, and returns -1
> through it:
>
> net/batman-adv/routing.c: In function 'receive_bat_packet':
> net/batman-adv/routing.c:739: warning: comparison is always false due to
> limited range of data type
>
> Use int instead.
>
[...]
> -static char count_real_packets(struct ethhdr *ethhdr,
> - struct batman_packet *batman_packet,
> - struct hard_iface *if_incoming)
> +static int count_real_packets(struct ethhdr *ethhdr,
> + struct batman_packet *batman_packet,
> + struct hard_iface *if_incoming)
> {
This one doesn't apply on linux-next/net-next-2.6, but I will fix it by hand.
Thanks,
Sven
[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2011-06-15 5:59 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-14 23:51 [B.A.T.M.A.N.] [PATCH 1/2] batman-adv: count_real_packets() in batman-adv assumes char is signed David Howells
2011-06-14 23:51 ` [B.A.T.M.A.N.] [PATCH 2/2] batman-adv: compare_eth() should take const pointer arguments David Howells
2011-06-15 5:56 ` Sven Eckelmann
2011-06-15 5:59 ` Sven Eckelmann [this message]
2011-06-15 6:58 ` [B.A.T.M.A.N.] [PATCH 1/2] batman-adv: count_real_packets() in batman-adv assumes char is signed Sven Eckelmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201106150759.15643.sven@narfation.org \
--to=sven@narfation.org \
--cc=b.a.t.m.a.n@lists.open-mesh.org \
--cc=dhowells@redhat.com \
--cc=lindner_marek@yahoo.de \
--cc=netdev@vger.kernel.org \
--cc=siwu@hrz.tu-chemnitz.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox