From: Marek Lindner <lindner_marek@yahoo.de>
To: The list for a Better Approach To Mobile Ad-hoc Networking
<b.a.t.m.a.n@lists.open-mesh.org>
Subject: Re: [B.A.T.M.A.N.] [PATCH 2/3] batman-adv: count_real_packets() in batman-adv assumes char is signed
Date: Wed, 15 Jun 2011 21:04:15 +0200 [thread overview]
Message-ID: <201106152104.16054.lindner_marek@yahoo.de> (raw)
In-Reply-To: <1308123697-7893-2-git-send-email-sven@narfation.org>
On Wednesday, June 15, 2011 09:41:36 AM Sven Eckelmann wrote:
> From: David Howells <dhowells@redhat.com>
>
> count_real_packets() in batman-adv assumes char is signed, and returns -1
> through it:
>
> net/batman-adv/routing.c: In function 'receive_bat_packet':
> net/batman-adv/routing.c:739: warning: comparison is always false due to
> limited range of data type
>
> Use int instead.
Applied in revision fdc8438.
Thanks,
Marek
next prev parent reply other threads:[~2011-06-15 19:04 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-15 7:41 [B.A.T.M.A.N.] [PATCH 1/3] batman-adv: Fix line over 80 characters Sven Eckelmann
2011-06-15 7:41 ` [B.A.T.M.A.N.] [PATCH 2/3] batman-adv: count_real_packets() in batman-adv assumes char is signed Sven Eckelmann
2011-06-15 19:04 ` Marek Lindner [this message]
2011-06-15 7:41 ` [B.A.T.M.A.N.] [PATCH 3/3] batman-adv: Reduce usage of char Sven Eckelmann
2011-06-15 20:27 ` Marek Lindner
2011-06-15 18:58 ` [B.A.T.M.A.N.] [PATCH 1/3] batman-adv: Fix line over 80 characters Marek Lindner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201106152104.16054.lindner_marek@yahoo.de \
--to=lindner_marek@yahoo.de \
--cc=b.a.t.m.a.n@lists.open-mesh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox