* [B.A.T.M.A.N.] [PATCH] batman-adv: Keep interface_tx as local function
@ 2011-06-15 13:17 Sven Eckelmann
2011-06-15 20:31 ` Marek Lindner
0 siblings, 1 reply; 2+ messages in thread
From: Sven Eckelmann @ 2011-06-15 13:17 UTC (permalink / raw)
To: b.a.t.m.a.n
interface_tx is not used outside of soft-interface.c and thus doesn't
need to be declared inside soft-interface.h
Signed-off-by: Sven Eckelmann <sven@narfation.org>
---
soft-interface.c | 2 +-
soft-interface.h | 1 -
2 files changed, 1 insertions(+), 2 deletions(-)
diff --git a/soft-interface.c b/soft-interface.c
index 7aeed0d..7c554b4 100644
--- a/soft-interface.c
+++ b/soft-interface.c
@@ -554,7 +554,7 @@ static int interface_change_mtu(struct net_device *dev, int new_mtu)
return 0;
}
-int interface_tx(struct sk_buff *skb, struct net_device *soft_iface)
+static int interface_tx(struct sk_buff *skb, struct net_device *soft_iface)
{
struct ethhdr *ethhdr = (struct ethhdr *)skb->data;
struct bat_priv *bat_priv = netdev_priv(soft_iface);
diff --git a/soft-interface.h b/soft-interface.h
index c24906d..001546f 100644
--- a/soft-interface.h
+++ b/soft-interface.h
@@ -25,7 +25,6 @@
int my_skb_head_push(struct sk_buff *skb, unsigned int len);
int softif_neigh_seq_print_text(struct seq_file *seq, void *offset);
void softif_neigh_purge(struct bat_priv *bat_priv);
-int interface_tx(struct sk_buff *skb, struct net_device *soft_iface);
void interface_rx(struct net_device *soft_iface,
struct sk_buff *skb, struct hard_iface *recv_if,
int hdr_size);
--
1.7.5.3
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [B.A.T.M.A.N.] [PATCH] batman-adv: Keep interface_tx as local function
2011-06-15 13:17 [B.A.T.M.A.N.] [PATCH] batman-adv: Keep interface_tx as local function Sven Eckelmann
@ 2011-06-15 20:31 ` Marek Lindner
0 siblings, 0 replies; 2+ messages in thread
From: Marek Lindner @ 2011-06-15 20:31 UTC (permalink / raw)
To: The list for a Better Approach To Mobile Ad-hoc Networking
On Wednesday, June 15, 2011 03:17:21 PM Sven Eckelmann wrote:
> interface_tx is not used outside of soft-interface.c and thus doesn't
> need to be declared inside soft-interface.h
Applied in revision 307e22c.
Thanks,
Marek
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2011-06-15 20:31 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-06-15 13:17 [B.A.T.M.A.N.] [PATCH] batman-adv: Keep interface_tx as local function Sven Eckelmann
2011-06-15 20:31 ` Marek Lindner
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox