From: Simon Wunderlich <simon.wunderlich@s2003.tu-chemnitz.de>
To: The list for a Better Approach To Mobile Ad-hoc Networking
<b.a.t.m.a.n@lists.open-mesh.org>
Subject: Re: [B.A.T.M.A.N.] [PATCH 1/2] batman-adv: Don't use EXTRA_CFLAGS to add source version
Date: Sat, 1 Oct 2011 00:35:05 +0200 [thread overview]
Message-ID: <20110930223505.GA30938@pandem0nium> (raw)
In-Reply-To: <1317382322-6922-1-git-send-email-sven@narfation.org>
[-- Attachment #1: Type: text/plain, Size: 1678 bytes --]
Hey there,
I've applied it and tested on kernel releases 2.6.29 - 3.1-rc2, and
it compiled just fine. EXTRA_CFLAGS is still applied when set.
I can Ack this. ;)
Cheers,
Simon
On Fri, Sep 30, 2011 at 01:32:00PM +0200, Sven Eckelmann wrote:
> EXTRA_CFLAGS is deprecated since v2.6.23-2309-gf77bf01 and should not be used
> anymore to add additional flags for the c compiler.
>
> Signed-off-by: Sven Eckelmann <sven@narfation.org>
> ---
> Makefile.kbuild | 4 ++--
> README | 4 ++--
> 2 files changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/Makefile.kbuild b/Makefile.kbuild
> index 6377c17..bd7e93c 100644
> --- a/Makefile.kbuild
> +++ b/Makefile.kbuild
> @@ -25,10 +25,10 @@ ifeq ($(MAKING_MODULES),1)
> -include $(TOPDIR)/Rules.make
> endif
>
> -# EXTRA_CFLAGS += -DCONFIG_BATMAN_ADV_DEBUG
> +# ccflags-y += -DCONFIG_BATMAN_ADV_DEBUG
>
> ifneq ($(REVISION),)
> -EXTRA_CFLAGS += -DSOURCE_VERSION=\"$(REVISION)\"
> +ccflags-y += -DSOURCE_VERSION=\"$(REVISION)\"
> endif
>
> obj-m += batman-adv.o
> diff --git a/README b/README
> index 1e000ee..5ba56b5 100644
> --- a/README
> +++ b/README
> @@ -1,4 +1,4 @@
> -[state: 21-08-2011]
> +[state: 30-09-2011]
>
> BATMAN-ADV
> ----------
> @@ -206,7 +206,7 @@ option "B.A.T.M.A.N. debugging". When compiling outside of the
> kernel tree it is necessary to edit the file Makefile.kbuild and
> uncomment the line
>
> -#EXTRA_CFLAGS += -DCONFIG_BATMAN_ADV_DEBUG
> +#ccflags-y += -DCONFIG_BATMAN_ADV_DEBUG
>
> Those additional debug messages can be accessed using a special
> file in debugfs
> --
> 1.7.6.3
>
>
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 198 bytes --]
next prev parent reply other threads:[~2011-09-30 22:35 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-30 11:32 [B.A.T.M.A.N.] [PATCH 1/2] batman-adv: Don't use EXTRA_CFLAGS to add source version Sven Eckelmann
2011-09-30 11:32 ` [B.A.T.M.A.N.] [PATCH 2/2] batman-adv: Replace obsolete strict_strto<foo> with kstrto<foo> Sven Eckelmann
2011-10-02 15:21 ` Marek Lindner
2011-09-30 22:35 ` Simon Wunderlich [this message]
2011-10-02 15:19 ` [B.A.T.M.A.N.] [PATCH 1/2] batman-adv: Don't use EXTRA_CFLAGS to add source version Marek Lindner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110930223505.GA30938@pandem0nium \
--to=simon.wunderlich@s2003.tu-chemnitz.de \
--cc=b.a.t.m.a.n@lists.open-mesh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox