[B.A.T.M.A.N.] Compile error on openwrt with new patch

[B.A.T.M.A.N.] Compile error on openwrt with new patch

[Filippo Sallemi]

Hi all,
after an ./script/feeds update when i try to build openwrt I get an
error on batman-adv package:

Applying ./patches/batman-adv_correctly_set_the_data_field_in_the_TT_REPONSE_packet.patch
using plaintext:
patching file translation-table.c
Hunk #1 FAILED at 1054.
Hunk #2 succeeded at 632 with fuzz 2 (offset -448 lines).
1 out of 2 hunks FAILED -- saving rejects to file translation-table.c.rej
Patch failed!  Please fix
./patches/batman-adv_correctly_set_the_data_field_in_the_TT_REPONSE_packet.patch!

Rgds

-- 
Filippo Sallemi

Re: [B.A.T.M.A.N.] Compile error on openwrt with new patch

[Marek Lindner]

Hi,

> after an ./script/feeds update when i try to build openwrt I get an
> error on batman-adv package:
> 
> Applying
> ./patches/batman-adv_correctly_set_the_data_field_in_the_TT_REPONSE_packet
> .patch using plaintext:
> patching file translation-table.c
> Hunk #1 FAILED at 1054.
> Hunk #2 succeeded at 632 with fuzz 2 (offset -448 lines).
> 1 out of 2 hunks FAILED -- saving rejects to file translation-table.c.rej
> Patch failed!  Please fix
> ./patches/batman-adv_correctly_set_the_data_field_in_the_TT_REPONSE_packet.
> patch!

works for me. Do you have additional patches in your patches folder which are 
incompatible ?

Regards,
Marek

Re: [B.A.T.M.A.N.] Compile error on openwrt with new patch

[Filippo Sallemi]

No my patch folder was empty before update. Now the only way to
compile batman-adv is to revert to last version.

N.B. Here the command executed after first time error

1. svn clean;
2. svn distclean;
3. make -j 3

So I build a vergin openwrt with only batman-adv module but the error persist.


2011/10/18 Marek Lindner <lindner_marek@yahoo.de>:
>
> Hi,
>
>> after an ./script/feeds update when i try to build openwrt I get an
>> error on batman-adv package:
>>
>> Applying
>> ./patches/batman-adv_correctly_set_the_data_field_in_the_TT_REPONSE_packet
>> .patch using plaintext:
>> patching file translation-table.c
>> Hunk #1 FAILED at 1054.
>> Hunk #2 succeeded at 632 with fuzz 2 (offset -448 lines).
>> 1 out of 2 hunks FAILED -- saving rejects to file translation-table.c.rej
>> Patch failed!  Please fix
>> ./patches/batman-adv_correctly_set_the_data_field_in_the_TT_REPONSE_packet.
>> patch!
>
> works for me. Do you have additional patches in your patches folder which are
> incompatible ?
>
> Regards,
> Marek
>



-- 
Filippo Sallemi

Re: [B.A.T.M.A.N.] Compile error on openwrt with new patch

[Filippo Sallemi]

opps sorry

1. make clean
2. make distclean
3. make -j 3

2011/10/18 Filippo Sallemi <tonyputi@gmail.com>:
> No my patch folder was empty before update. Now the only way to
> compile batman-adv is to revert to last version.
>
> N.B. Here the command executed after first time error
>
> 1. svn clean;
> 2. svn distclean;
> 3. make -j 3
>
> So I build a vergin openwrt with only batman-adv module but the error persist.
>
>
> 2011/10/18 Marek Lindner <lindner_marek@yahoo.de>:
>>
>> Hi,
>>
>>> after an ./script/feeds update when i try to build openwrt I get an
>>> error on batman-adv package:
>>>
>>> Applying
>>> ./patches/batman-adv_correctly_set_the_data_field_in_the_TT_REPONSE_packet
>>> .patch using plaintext:
>>> patching file translation-table.c
>>> Hunk #1 FAILED at 1054.
>>> Hunk #2 succeeded at 632 with fuzz 2 (offset -448 lines).
>>> 1 out of 2 hunks FAILED -- saving rejects to file translation-table.c.rej
>>> Patch failed!  Please fix
>>> ./patches/batman-adv_correctly_set_the_data_field_in_the_TT_REPONSE_packet.
>>> patch!
>>
>> works for me. Do you have additional patches in your patches folder which are
>> incompatible ?
>>
>> Regards,
>> Marek
>>
>
>
>
> --
> Filippo Sallemi
>



-- 
Filippo Sallemi

Re: [B.A.T.M.A.N.] Compile error on openwrt with new patch

[Antonio Quartulli]

Hi Filippo,

On Tue, Oct 18, 2011 at 07:36:27 +0200, Filippo Sallemi wrote:
> opps sorry
> 
> 1. make clean
> 2. make distclean
> 3. make -j 3
> 

it works here..

can I suggest you to run "make V=99" and write down what the log
says? In this way that we can better understand what it is going on.

Moreover..did you get the last version of that patch? In the ml sometimes you
can find several version of the same patch. Please ensure it is the last one
(version 2)

Cheers,

> 2011/10/18 Filippo Sallemi <tonyputi@gmail.com>:
> > No my patch folder was empty before update. Now the only way to
> > compile batman-adv is to revert to last version.
> >
> > N.B. Here the command executed after first time error
> >
> > 1. svn clean;
> > 2. svn distclean;
> > 3. make -j 3
> >
> > So I build a vergin openwrt with only batman-adv module but the error persist.
> >
> >
> > 2011/10/18 Marek Lindner <lindner_marek@yahoo.de>:
> >>
> >> Hi,
> >>
> >>> after an ./script/feeds update when i try to build openwrt I get an
> >>> error on batman-adv package:
> >>>
> >>> Applying
> >>> ./patches/batman-adv_correctly_set_the_data_field_in_the_TT_REPONSE_packet
> >>> .patch using plaintext:
> >>> patching file translation-table.c
> >>> Hunk #1 FAILED at 1054.
> >>> Hunk #2 succeeded at 632 with fuzz 2 (offset -448 lines).
> >>> 1 out of 2 hunks FAILED -- saving rejects to file translation-table.c.rej
> >>> Patch failed!  Please fix
> >>> ./patches/batman-adv_correctly_set_the_data_field_in_the_TT_REPONSE_packet.
> >>> patch!
> >>
> >> works for me. Do you have additional patches in your patches folder which are
> >> incompatible ?
> >>
> >> Regards,
> >> Marek
> >>
> >
> >
> >
> > --
> > Filippo Sallemi
> >
> 
> 
> 
> -- 
> Filippo Sallemi

-- 
Antonio Quartulli

..each of us alone is worth nothing..
Ernesto "Che" Guevara

Re: [B.A.T.M.A.N.] Compile error on openwrt with new patch

[Marek Lindner]

On Tuesday, October 18, 2011 19:51:47 Antonio Quartulli wrote:
> Moreover..did you get the last version of that patch? In the ml sometimes
> you can find several version of the same patch. Please ensure it is the
> last one (version 2)

He is talking about the patch that is part of the batman-adv package in 
OpenWRT. I included the last version of your fixes, so that people can enjoy a 
(mostly) bugfree batman-adv without having to search on the mailing list.

Regards,
Marek

Re: [B.A.T.M.A.N.] Compile error on openwrt with new patch

[Sven Eckelmann]

[-- Attachment #1: Type: text/plain, Size: 802 bytes --]

On Tuesday 18 October 2011 13:59:18 Filippo Sallemi wrote:
> Hi all,
> after an ./script/feeds update when i try to build openwrt I get an
> error on batman-adv package:
> 
> Applying
> ./patches/batman-adv_correctly_set_the_data_field_in_the_TT_REPONSE_packet.
> patch using plaintext:
> patching file translation-table.c
> Hunk #1 FAILED at 1054.
> Hunk #2 succeeded at 632 with fuzz 2 (offset -448 lines).
> 1 out of 2 hunks FAILED -- saving rejects to file translation-table.c.rej
> Patch failed!  Please fix
> ./patches/batman-adv_correctly_set_the_data_field_in_the_TT_REPONSE_packet.p
> atch!

Please create a new checkout of openwrt, add the feed, add batman-adv to the 
config and build it with V=99 (the clean checkout not an old one). Add the 
.config and the log to you mail.

Thanks,
	Sven

[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

Re: [B.A.T.M.A.N.] Compile error on openwrt with new patch

[Sven Eckelmann]

[-- Attachment #1: Type: text/plain, Size: 1529 bytes --]

On Tuesday 18 October 2011 20:57:53 Filippo Sallemi wrote:
[...]
> > Please create a new checkout of openwrt, add the feed, add batman-adv to
> > the config and build it with V=99 (the clean checkout not an old one).
> > Add the .config and the log to you mail.
> > 
> > Thanks,
> >        Sven
> 
> This is my make V=99 output after make distclean and however a fresh
> checkout of openwrt.

No, that wasn't what I asked for.

> 
> make[3]: Entering directory
> `/home/fsallemi/Develop/backfire/feeds/packages/net/batman-adv'
> gzip -dc /home/fsallemi/Develop/backfire/dl/batman-adv-2011.2.0.tar.gz

What is that? 2011.3.0 with patches from 2011.3.0... this will _not_ work.

> 
> | /bin/tar -C
> | /home/fsallemi/Develop/backfire/build_dir/target-mips_r2_uClibc-0.9.30.
> | 1/batman-adv/batman-adv-2011.2.0/..
> 
> -xf -
> 
> Applying
> ./patches/batman-adv_correctly_set_the_data_field_in_the_TT_REPONSE_packet.
> patch using plaintext:
> patching file translation-table.c
> Hunk #1 FAILED at 1054.
> Hunk #2 succeeded at 632 with fuzz 2 (offset -448 lines).
> 1 out of 2 hunks FAILED -- saving rejects to file translation-table.c.rej
> Patch failed!  Please fix
> ./patches/batman-adv_correctly_set_the_data_field_in_the_TT_REPONSE_packet.p
> atch! make[3]: ***

This is a patch for 2011.3.0 and not for 2011.2.0

> [/home/fsallemi/Develop/backfire/build_dir/target-mips_r2_uClibc-0.9.30.1/b
> atman-adv/batman-adv-2011.2.0/.prepared_d634b3efc2524a3909e7512491480870]
> Error 1

This says 2011.2.0

[,,,]

Kind regards,
	Sven

[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

Re: [B.A.T.M.A.N.] Compile error on openwrt with new patch

[Sven Eckelmann]

[-- Attachment #1: Type: text/plain, Size: 2411 bytes --]


----------  Forwarded Message  ----------

Subject: Re: Re: [B.A.T.M.A.N.] Compile error on openwrt with new patch
Date: Tuesday 18 October 2011, 21:11:51
From: Filippo Sallemi <tonyputi@gmail.com>
To: Sven Eckelmann <sven@narfation.org>

Ok but i'm using backfire 10.03 with "package" url of
feeds.default.conf and in this version the makefile is for batman-adv
2011.2.0.

in my feeds.conf.default i have:
src-svn packages
svn://svn.openwrt.org/openwrt/branches/packages_10.03.1
svn://svn.openwrt.org/openwrt/packages

and in svn://svn.openwrt.org/openwrt/branches/packages_10.03.1 there
is batman-adv 2011.2.0 package.

It is a openwrt problem? my feeds.conf.default is the original openwrt conf.

Rgds


2011/10/18 Sven Eckelmann <sven@narfation.org>:
> On Tuesday 18 October 2011 20:57:53 Filippo Sallemi wrote:
> [...]
>> > Please create a new checkout of openwrt, add the feed, add batman-adv to
>> > the config and build it with V=99 (the clean checkout not an old one).
>> > Add the .config and the log to you mail.
>> >
>> > Thanks,
>> >        Sven
>>
>> This is my make V=99 output after make distclean and however a fresh
>> checkout of openwrt.
>
> No, that wasn't what I asked for.
>
>>
>> make[3]: Entering directory
>> `/home/fsallemi/Develop/backfire/feeds/packages/net/batman-adv'
>> gzip -dc /home/fsallemi/Develop/backfire/dl/batman-adv-2011.2.0.tar.gz
>
> What is that? 2011.3.0 with patches from 2011.3.0... this will _not_ work.
>
>>
>> | /bin/tar -C
>> | /home/fsallemi/Develop/backfire/build_dir/target-mips_r2_uClibc-0.9.30.
>> | 1/batman-adv/batman-adv-2011.2.0/..
>>
>> -xf -
>>
>> Applying
>> ./patches/batman-adv_correctly_set_the_data_field_in_the_TT_REPONSE_packet.
>> patch using plaintext:
>> patching file translation-table.c
>> Hunk #1 FAILED at 1054.
>> Hunk #2 succeeded at 632 with fuzz 2 (offset -448 lines).
>> 1 out of 2 hunks FAILED -- saving rejects to file translation-table.c.rej
>> Patch failed!  Please fix
>> ./patches/batman-
adv_correctly_set_the_data_field_in_the_TT_REPONSE_packet.p
>> atch! make[3]: ***
>
> This is a patch for 2011.3.0 and not for 2011.2.0
>
>> [/home/fsallemi/Develop/backfire/build_dir/target-mips_r2_uClibc-0.9.30.1/b
>> atman-adv/batman-adv-2011.2.0/.prepared_d634b3efc2524a3909e7512491480870]
>> Error 1
>
> This says 2011.2.0
>
> [,,,]
>
> Kind regards,
>        Sven



-- 
Filippo Sallemi
-----------------------------------------

[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

Re: [B.A.T.M.A.N.] Compile error on openwrt with new patch

[Marek Lindner]

Filippo,

could you please always send your mails to the mailing list ? If you stop 
sending to the list we don't know what is gloing on.


> and in svn://svn.openwrt.org/openwrt/branches/packages_10.03.1 there
> is batman-adv 2011.2.0 package.
> 
> It is a openwrt problem? my feeds.conf.default is the original openwrt
> conf.

Yes, it seems that Jow from the OpenWrt team has copied the patches intended 
for batman-adv 2011.3.0 to 2011.2.0.

@Jow: Could you please revert the comitts 28473 and 28477.

Thanks,
Marek

Re: [B.A.T.M.A.N.] Compile error on openwrt with new patch

[Filippo Sallemi]

oops sorry

2011/10/18 Marek Lindner <lindner_marek@yahoo.de>:
>
> Filippo,
>
> could you please always send your mails to the mailing list ? If you stop
> sending to the list we don't know what is gloing on.
>
>
>> and in svn://svn.openwrt.org/openwrt/branches/packages_10.03.1 there
>> is batman-adv 2011.2.0 package.
>>
>> It is a openwrt problem? my feeds.conf.default is the original openwrt
>> conf.
>
> Yes, it seems that Jow from the OpenWrt team has copied the patches intended
> for batman-adv 2011.3.0 to 2011.2.0.
>
> @Jow: Could you please revert the comitts 28473 and 28477.
>
> Thanks,
> Marek
>



-- 
Filippo Sallemi

Re: [B.A.T.M.A.N.] Compile error on openwrt with new patch

[Filippo Sallemi]

Sorry Marek, but how much is stable batman.2011.3.0 ? Can I use it in
production?

Rgds


2011/10/18 Filippo Sallemi <tonyputi@gmail.com>:
> oops sorry
>
> 2011/10/18 Marek Lindner <lindner_marek@yahoo.de>:
>>
>> Filippo,
>>
>> could you please always send your mails to the mailing list ? If you stop
>> sending to the list we don't know what is gloing on.
>>
>>
>>> and in svn://svn.openwrt.org/openwrt/branches/packages_10.03.1 there
>>> is batman-adv 2011.2.0 package.
>>>
>>> It is a openwrt problem? my feeds.conf.default is the original openwrt
>>> conf.
>>
>> Yes, it seems that Jow from the OpenWrt team has copied the patches intended
>> for batman-adv 2011.3.0 to 2011.2.0.
>>
>> @Jow: Could you please revert the comitts 28473 and 28477.
>>
>> Thanks,
>> Marek
>>
>
>
>
> --
> Filippo Sallemi
>



-- 
Filippo Sallemi

Re: [B.A.T.M.A.N.] Compile error on openwrt with new patch

[Sven Eckelmann]

[-- Attachment #1: Type: text/plain, Size: 492 bytes --]

On Tuesday 18 October 2011 21:26:26 Filippo Sallemi wrote:
> Sorry Marek, but how much is stable batman.2011.3.0 ? Can I use it in
> production?

The release itself is not as stable as we wanted. That's why we added those 
critical patches and will release version 2011.3.1 in the near future.

Beside those fixed(!!!) problems, no other problem is known. But we cannot 
guarantee that 2011.3.1 is more stable than 2011.2.0 or that 2011.2.0 is more 
stable than 2011.3.1.

Kind regards,
	Sven

[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

Re: [B.A.T.M.A.N.] Compile error on openwrt with new patch

[Jo-Philipp Wich]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Done, sorry for the confusion.

~ Jow
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iEYEARECAAYFAk6d0pcACgkQdputYINPTPPiIQCfZihL5Ux+9Dwcg18iXUv8SUel
glgAnRsXcWrXvPDHSpVVLKQ7+lmjxiKh
=WuZn
-----END PGP SIGNATURE-----

Re: [B.A.T.M.A.N.] Compile error on openwrt with new patch

[Marek Lindner]

On Tuesday, October 18, 2011 21:25:11 Jo-Philipp Wich wrote:
> Done, sorry for the confusion.

Thanks!

I did not know such a "stable" branch existed. If you prefer I can maintain it 
myself. If so, what are the policies for this branch ?


Regards,
Marek

Re: [B.A.T.M.A.N.] Compile error on openwrt with new patch

[Jo-Philipp Wich]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

It was opened a few weeks ago to freeze packages for the Backfire
release. It should only receive bugfixes anymore.

~ Jow
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iEYEARECAAYFAk6d20gACgkQdputYINPTPPKKgCglM5ch+vnK7LOKIeGoRSrn3qR
kj0An1Pxz1ZovLkXZ3LbgpP58RJMNLfw
=aAM4
-----END PGP SIGNATURE-----

Re: [B.A.T.M.A.N.] Compile error on openwrt with new patch

[Marek Lindner]

On Tuesday, October 18, 2011 22:02:16 Jo-Philipp Wich wrote:
> It was opened a few weeks ago to freeze packages for the Backfire
> release. It should only receive bugfixes anymore.

Ok, then it should be fine. 2011.2.0 was a bugfix release and we have no open 
bug reports for it. No need to update it further.

Regards,
Marek