From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: From: Marek Lindner Date: Wed, 19 Oct 2011 11:20:47 +0200 References: <1319014945-32281-1-git-send-email-siwu@hrz.tu-chemnitz.de> In-Reply-To: <1319014945-32281-1-git-send-email-siwu@hrz.tu-chemnitz.de> MIME-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-15" Content-Transfer-Encoding: 7bit Message-Id: <201110191120.48103.lindner_marek@yahoo.de> Subject: Re: [B.A.T.M.A.N.] [PATCH] batman-adv: remove references for global tt entries Reply-To: The list for a Better Approach To Mobile Ad-hoc Networking List-Id: The list for a Better Approach To Mobile Ad-hoc Networking List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: The list for a Better Approach To Mobile Ad-hoc Networking On Wednesday, October 19, 2011 11:02:25 Simon Wunderlich wrote: > struct tt_global_entry holds a reference to an orig_node which must be > decremented before deallocating the structure. > > Signed-off-by: Simon Wunderlich > --- > compat.c | 8 -------- > compat.h | 1 - > translation-table.c | 14 +++++++++++++- > 3 files changed, 13 insertions(+), 10 deletions(-) > > diff --git a/compat.c b/compat.c > index 88ceb40..1793904 100644 > --- a/compat.c > +++ b/compat.c > @@ -36,12 +36,4 @@ void free_rcu_tt_local_entry(struct rcu_head *rcu) > kfree(tt_local_entry); > } > > -void free_rcu_tt_global_entry(struct rcu_head *rcu) > -{ > - struct tt_global_entry *tt_global_entry; > - > - tt_global_entry = container_of(rcu, struct tt_global_entry, rcu); > - kfree(tt_global_entry); > -} If you remove the function from compat.c please also remove its declaration in compat.h. Thanks, Marek