Re: [B.A.T.M.A.N.] [PATCH 1/2] batman-adv: Fix style changes reported by cppcheck

Simon Wunderlich
2011-10-30T20:58:26Z

[-- Attachment #1: Type: text/plain, Size: 1094 bytes --]

Hey,

Patch 2/2 was created accidently due to my lack of git skills, please
assume [PATCH]. :)

The output of cppcheck (before the applying the patch):

$ cppcheck -q --enable=all .
[bat_iv_ogm.c:993]: (style) The scope of the variable 'offset' can be reduced
[routing.c:980]: (style) The scope of the variable 'ret' can be reduced
[soft-interface.c:695]: (style) The scope of the variable 'ret' can be reduced

Note that reduced scope may be a matter of taste, I could not really find
anything about that in the CodingStyle.

Cheers
Simon

On Sun, Oct 30, 2011 at 09:24:31PM +0100, Marek Lindner wrote:
> On Sunday, October 30, 2011 16:36:20 Simon Wunderlich wrote:
> > cppcheck reported some style issues this patch fixes.
> >
> > Signed-off-by: Simon Wunderlich <siwu@hrz.tu-chemnitz.de>
> > ---
> > bat_iv_ogm.c | 2 +-
> > routing.c | 2 +-
> > soft-interface.c | 2 +-
> > 3 files changed, 3 insertions(+), 3 deletions(-)
>
> Do you mind saying what cppcheck reported ?
> What happened to patch 2/2 ?
>
> Regards,
> Marek
>

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 198 bytes --]