From: Marek Lindner <lindner_marek@yahoo.de>
To: The list for a Better Approach To Mobile Ad-hoc Networking
<b.a.t.m.a.n@lists.open-mesh.org>
Subject: Re: [B.A.T.M.A.N.] [RFC 11/11] [RFC] batman-adv: get primaries address through bat_priv->own_orig
Date: Tue, 1 Nov 2011 11:08:47 +0100 [thread overview]
Message-ID: <201111011108.48015.lindner_marek@yahoo.de> (raw)
In-Reply-To: <1320015072-10313-12-git-send-email-siwu@hrz.tu-chemnitz.de>
On Sunday, October 30, 2011 23:51:12 Simon Wunderlich wrote:
> Instead of acquiring the first interfaces originator through
> hard interface (including referencing/dereferencing), we can use the
> cached value in bat_priv->own_orig.
>
> There might be some cases where this function was implicitly used to
> check whether there is a hard interface configured at all (i.e. if
> batman is active), therfore this is patch is an RFC.
Most of the functions do not simply retrieve the addr but also check if there
is a primary interface. So, what happens if batman-adv has no primary_if ?
AFAIK that can occur if all added hard-interfaces are down.
What happens with BLAII if there is no primary interface ?
Cheers,
Marek
next prev parent reply other threads:[~2011-11-01 10:08 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-30 22:51 [B.A.T.M.A.N.] [RFC 00/11] bridge loop avoidance II Simon Wunderlich
2011-10-30 22:51 ` [B.A.T.M.A.N.] [RFC 01/11] batman-adv: remove old bridge loop avoidance code Simon Wunderlich
2011-10-30 22:51 ` [B.A.T.M.A.N.] [RFC 02/11] batman-adv: add basic " Simon Wunderlich
2011-10-30 23:20 ` Marek Lindner
2011-10-31 0:00 ` Simon Wunderlich
2011-11-01 10:52 ` Marek Lindner
2011-11-02 11:01 ` Simon Wunderlich
2011-10-30 22:51 ` [B.A.T.M.A.N.] [RFC 03/11] batman-adv: make bridge loop avoidance switchable Simon Wunderlich
2011-10-30 22:51 ` [B.A.T.M.A.N.] [RFC 04/11] batman-adv: export claim tables through debugfs Simon Wunderlich
2011-10-30 22:51 ` [B.A.T.M.A.N.] [RFC 05/11] batman-adv: allow multiple entries in tt_global_entries Simon Wunderlich
2011-10-30 22:51 ` [B.A.T.M.A.N.] [RFC 06/11] batman-adv: don't let backbone gateways exchange tt entries Simon Wunderlich
2011-10-30 22:51 ` [B.A.T.M.A.N.] [RFC 07/11] batman-adv: add broadcast duplicate check Simon Wunderlich
2011-11-01 10:47 ` Marek Lindner
2011-11-02 11:07 ` Simon Wunderlich
2011-10-30 22:51 ` [B.A.T.M.A.N.] [RFC 08/11] batman-adv: drop STP over batman Simon Wunderlich
2011-10-30 22:51 ` [B.A.T.M.A.N.] [RFC 09/11] batman-adv: form groups in the bridge loop avoidance Simon Wunderlich
2011-10-30 22:51 ` [B.A.T.M.A.N.] [RFC 10/11] batman-adv: Update README and sysfs description Simon Wunderlich
2011-10-30 22:51 ` [B.A.T.M.A.N.] [RFC 11/11] [RFC] batman-adv: get primaries address through bat_priv->own_orig Simon Wunderlich
2011-11-01 10:08 ` Marek Lindner [this message]
2011-11-04 15:17 ` Simon Wunderlich
2011-10-31 0:52 ` [B.A.T.M.A.N.] [RFC 00/11] bridge loop avoidance II Simon Wunderlich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201111011108.48015.lindner_marek@yahoo.de \
--to=lindner_marek@yahoo.de \
--cc=b.a.t.m.a.n@lists.open-mesh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox