From: Simon Wunderlich <simon.wunderlich@s2003.tu-chemnitz.de>
To: The list for a Better Approach To Mobile Ad-hoc Networking
<b.a.t.m.a.n@lists.open-mesh.org>
Subject: Re: [B.A.T.M.A.N.] [RFC 11/11] [RFC] batman-adv: get primaries address through bat_priv->own_orig
Date: Fri, 4 Nov 2011 16:17:56 +0100 [thread overview]
Message-ID: <20111104151756.GA12738@pandem0nium> (raw)
In-Reply-To: <201111011108.48015.lindner_marek@yahoo.de>
[-- Attachment #1: Type: text/plain, Size: 1803 bytes --]
Hey Marek,
as per our IRC discussion, I'm removing this RFC patch as well as the
primary_addr caching in the bla code to avoid any debugging complexity with
this cache. I first introduced it to avoid code bloating to fetch/check/release
the primary_if in all the little functions, but I found an easy and non-bloating
way to do that. ;)
Regarding BLAII after this change, all functions hooked up somewhere (bla_rx(),
bla_tx(), bla_periodic_work(), ...) will more or less return as long as there
is no primary_if - it is needed to find out the own address after all.
When a new primary_if is chosen, the claim table and backbone gw table are wiped
to "simulate" a reboot - with the new interface, we might have new neighbors
in the mesh after all ...
The patch is already included in my blaII_dirty repo, I'll update and rebase
main patch series accordingly as there were no more comments in the last couple
of days.
Thanks
Simon
On Tue, Nov 01, 2011 at 11:08:47AM +0100, Marek Lindner wrote:
> On Sunday, October 30, 2011 23:51:12 Simon Wunderlich wrote:
> > Instead of acquiring the first interfaces originator through
> > hard interface (including referencing/dereferencing), we can use the
> > cached value in bat_priv->own_orig.
> >
> > There might be some cases where this function was implicitly used to
> > check whether there is a hard interface configured at all (i.e. if
> > batman is active), therfore this is patch is an RFC.
>
> Most of the functions do not simply retrieve the addr but also check if there
> is a primary interface. So, what happens if batman-adv has no primary_if ?
> AFAIK that can occur if all added hard-interfaces are down.
>
> What happens with BLAII if there is no primary interface ?
>
> Cheers,
> Marek
>
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 198 bytes --]
next prev parent reply other threads:[~2011-11-04 15:17 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-30 22:51 [B.A.T.M.A.N.] [RFC 00/11] bridge loop avoidance II Simon Wunderlich
2011-10-30 22:51 ` [B.A.T.M.A.N.] [RFC 01/11] batman-adv: remove old bridge loop avoidance code Simon Wunderlich
2011-10-30 22:51 ` [B.A.T.M.A.N.] [RFC 02/11] batman-adv: add basic " Simon Wunderlich
2011-10-30 23:20 ` Marek Lindner
2011-10-31 0:00 ` Simon Wunderlich
2011-11-01 10:52 ` Marek Lindner
2011-11-02 11:01 ` Simon Wunderlich
2011-10-30 22:51 ` [B.A.T.M.A.N.] [RFC 03/11] batman-adv: make bridge loop avoidance switchable Simon Wunderlich
2011-10-30 22:51 ` [B.A.T.M.A.N.] [RFC 04/11] batman-adv: export claim tables through debugfs Simon Wunderlich
2011-10-30 22:51 ` [B.A.T.M.A.N.] [RFC 05/11] batman-adv: allow multiple entries in tt_global_entries Simon Wunderlich
2011-10-30 22:51 ` [B.A.T.M.A.N.] [RFC 06/11] batman-adv: don't let backbone gateways exchange tt entries Simon Wunderlich
2011-10-30 22:51 ` [B.A.T.M.A.N.] [RFC 07/11] batman-adv: add broadcast duplicate check Simon Wunderlich
2011-11-01 10:47 ` Marek Lindner
2011-11-02 11:07 ` Simon Wunderlich
2011-10-30 22:51 ` [B.A.T.M.A.N.] [RFC 08/11] batman-adv: drop STP over batman Simon Wunderlich
2011-10-30 22:51 ` [B.A.T.M.A.N.] [RFC 09/11] batman-adv: form groups in the bridge loop avoidance Simon Wunderlich
2011-10-30 22:51 ` [B.A.T.M.A.N.] [RFC 10/11] batman-adv: Update README and sysfs description Simon Wunderlich
2011-10-30 22:51 ` [B.A.T.M.A.N.] [RFC 11/11] [RFC] batman-adv: get primaries address through bat_priv->own_orig Simon Wunderlich
2011-11-01 10:08 ` Marek Lindner
2011-11-04 15:17 ` Simon Wunderlich [this message]
2011-10-31 0:52 ` [B.A.T.M.A.N.] [RFC 00/11] bridge loop avoidance II Simon Wunderlich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111104151756.GA12738@pandem0nium \
--to=simon.wunderlich@s2003.tu-chemnitz.de \
--cc=b.a.t.m.a.n@lists.open-mesh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox