From: Marek Lindner <lindner_marek@yahoo.de>
To: The list for a Better Approach To Mobile Ad-hoc Networking
<b.a.t.m.a.n@lists.open-mesh.org>
Subject: Re: [B.A.T.M.A.N.] [PATCH] batctl: Human readable log levels instead of bitmasks
Date: Mon, 7 Nov 2011 20:00:12 +0800 [thread overview]
Message-ID: <201111072000.12918.lindner_marek@yahoo.de> (raw)
In-Reply-To: <1320666759-11791-1-git-send-email-martin@hundeboll.net>
On Monday, November 07, 2011 19:52:39 Martin Hundebøll wrote:
> As the number of log levels increases, it becomes less user friendly to
> assign a log level, as this is given as a bitmask in decimal form. This
> commit changes this, so that one or more log levels can be given as
> human readable words (e.g. "batctl ll batman routes").
The "Signed-off-by" is missing.
> + snprintf(str, 4, "%u", log_level);
> + res = write_file(path_buff, SYS_LOG_LEVEL, str, NULL);
Shouldn't it be "sizeof(str)" instead of "4" and "%i" instead of "%u" ?
Regards,
Marek
next prev parent reply other threads:[~2011-11-07 12:00 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-07 11:52 [B.A.T.M.A.N.] [PATCH] batctl: Human readable log levels instead of bitmasks Martin Hundebøll
2011-11-07 12:00 ` Marek Lindner [this message]
2011-11-07 12:14 ` [B.A.T.M.A.N.] [PATCHv2] " Martin Hundebøll
2011-11-08 17:41 ` Marek Lindner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201111072000.12918.lindner_marek@yahoo.de \
--to=lindner_marek@yahoo.de \
--cc=b.a.t.m.a.n@lists.open-mesh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox