[B.A.T.M.A.N.] [PATCH] add make install

[B.A.T.M.A.N.] [PATCH] add make install

[Alexey Fisher]

Signed-off-by: Alexey Fisher <bug-track@fisher-privat.net>
---
 Makefile |    3 +++
 1 files changed, 3 insertions(+), 0 deletions(-)

diff --git a/Makefile b/Makefile
index 5762721..44bad88 100644
--- a/Makefile
+++ b/Makefile
@@ -42,3 +42,6 @@ all:
 
 clean:
 	$(MAKE) -C $(KERNELPATH) M=$(PWD) PWD=$(PWD) clean
+
+install:
+	@cp batman-adv.ko $(shell dirname $(KERNELPATH))/kernel/net/batman-adv/batman-adv.ko
-- 
1.7.5.4

Re: [B.A.T.M.A.N.] [PATCH] add make install

[Sven Eckelmann]

[-- Attachment #1: Type: text/plain, Size: 889 bytes --]

On Monday 14 November 2011 10:11:32 Alexey Fisher wrote:
> Signed-off-by: Alexey Fisher <bug-track@fisher-privat.net>
> ---
>  Makefile |    3 +++
>  1 files changed, 3 insertions(+), 0 deletions(-)
> 
> diff --git a/Makefile b/Makefile
> index 5762721..44bad88 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -42,3 +42,6 @@ all:
> 
>  clean:
>  	$(MAKE) -C $(KERNELPATH) M=$(PWD) PWD=$(PWD) clean
> +
> +install:
> +	@cp batman-adv.ko $(shell dirname
> $(KERNELPATH))/kernel/net/batman-adv/batman-adv.ko

NAck: Sven Eckelmann <sven@narfation.org>

Please read in the current linux sources Documentation/kbuild/modules.txt

+install
+	$(MAKE) -C $(KERNELPATH) M=$(PWD) PWD=$(PWD) modules_install

or to override the old version that is included in the kernel

+install
+	$(MAKE) -C $(KERNELPATH) M=$(PWD) PWD=$(PWD) INSTALL_MOD_DIR=kernel/net/batman-adv/ modules_install

Kind regards,
	Sven

[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

Re: [B.A.T.M.A.N.] [PATCH] add make install

[Alexey Fisher]

On 14.11.2011 10:38, Sven Eckelmann wrote:
> On Monday 14 November 2011 10:11:32 Alexey Fisher wrote:
>> Signed-off-by: Alexey Fisher <bug-track@fisher-privat.net>
>> ---
>>  Makefile |    3 +++
>>  1 files changed, 3 insertions(+), 0 deletions(-)
>>
>> diff --git a/Makefile b/Makefile
>> index 5762721..44bad88 100644
>> --- a/Makefile
>> +++ b/Makefile
>> @@ -42,3 +42,6 @@ all:
>>
>>  clean:
>>  	$(MAKE) -C $(KERNELPATH) M=$(PWD) PWD=$(PWD) clean
>> +
>> +install:
>> +	@cp batman-adv.ko $(shell dirname
>> $(KERNELPATH))/kernel/net/batman-adv/batman-adv.ko
> 
> NAck: Sven Eckelmann <sven@narfation.org>
> 
> Please read in the current linux sources Documentation/kbuild/modules.txt
> 
> +install
> +	$(MAKE) -C $(KERNELPATH) M=$(PWD) PWD=$(PWD) modules_install
> 
> or to override the old version that is included in the kernel
> 
> +install
> +	$(MAKE) -C $(KERNELPATH) M=$(PWD) PWD=$(PWD) INSTALL_MOD_DIR=kernel/net/batman-adv/ modules_install

Thank you,
so you will send your patch? I prefer last version, to make testing easier.

regards,
Alexey.

Re: [B.A.T.M.A.N.] [PATCH] add make install

[Sven Eckelmann]

[-- Attachment #1: Type: text/plain, Size: 466 bytes --]

On Monday 14 November 2011 10:38:07 Sven Eckelmann wrote:
> On Monday 14 November 2011 10:11:32 Alexey Fisher wrote:
> > Signed-off-by: Alexey Fisher <bug-track@fisher-privat.net>
> > ---
> > 
> >  Makefile |    3 +++
> >  1 files changed, 3 insertions(+), 0 deletions(-)
[...]
> NAck: Sven Eckelmann <sven@narfation.org>

And also "Nack" for not updating the README [1]

Kind regards,
	Sven

[1] http://www.open-mesh.org/wiki/open-mesh/Contribute#Submitting-patches

[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

Re: [B.A.T.M.A.N.] [PATCH] add make install

[Sven Eckelmann]

[-- Attachment #1: Type: text/plain, Size: 519 bytes --]

On Monday 14 November 2011 11:19:19 Alexey Fisher wrote:
[...]
> Thank you,
> so you will send your patch? I prefer last version, to make testing easier.

I personally don't care. Feel free to fix your patch and send a new version 
(but think about adding the ":" after "install" -- the character magically 
disappeared when I wrote the mail).

And don't forget the documentation part as it is always hard to remember 
everything on the day the release is made, but easy when you just made the 
patch. :)

Thanks,
	Sven

[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

Re: [B.A.T.M.A.N.] [PATCH] add make install

[Alexey Fisher]

[-- Attachment #1: Type: text/plain, Size: 582 bytes --]

On 14.11.2011 11:29, Sven Eckelmann wrote:
> On Monday 14 November 2011 11:19:19 Alexey Fisher wrote:
> [...]
>> Thank you,
>> so you will send your patch? I prefer last version, to make testing easier.
> 
> I personally don't care. Feel free to fix your patch and send a new version 
> (but think about adding the ":" after "install" -- the character magically 
> disappeared when I wrote the mail).
> 
> And don't forget the documentation part as it is always hard to remember 
> everything on the day the release is made, but easy when you just made the 
> patch. :)

Corrected.

[-- Attachment #2: 0001-add-make-install-option.patch --]
[-- Type: text/x-patch, Size: 958 bytes --]

From 04e5cfa522d79a2a8764ee7ce04f8d0842ee37be Mon Sep 17 00:00:00 2001
From: Alexey Fisher <bug-track@fisher-privat.net>
Date: Mon, 14 Nov 2011 11:35:13 +0100
Subject: [PATCH] add "make install" option

Signed-off-by: Alexey Fisher <bug-track@fisher-privat.net>
---
 Makefile |    3 +++
 README   |    4 ++++
 2 files changed, 7 insertions(+), 0 deletions(-)

diff --git a/Makefile b/Makefile
index 5762721..3374687 100644
--- a/Makefile
+++ b/Makefile
@@ -42,3 +42,6 @@ all:
 
 clean:
 	$(MAKE) -C $(KERNELPATH) M=$(PWD) PWD=$(PWD) clean
+
+install:
+	$(MAKE) -C $(KERNELPATH) M=$(PWD) PWD=$(PWD) INSTALL_MOD_DIR=kernel/net/batman-adv/ modules_install
diff --git a/README b/README
index 5ba56b5..ec85dff 100644
--- a/README
+++ b/README
@@ -34,6 +34,10 @@ if you want to compile against some other kernel, use:
 
 # make KERNELPATH=/path/to/kernel
 
+if you wont to install this module:
+
+# sudo make install
+
 
 CONFIGURATION
 -------------
-- 
1.7.5.4

Re: [B.A.T.M.A.N.] [PATCH] add make install

[Marek Lindner]

On Monday, November 14, 2011 18:37:55 Alexey Fisher wrote:
> On 14.11.2011 11:29, Sven Eckelmann wrote:
> > On Monday 14 November 2011 11:19:19 Alexey Fisher wrote:
> > [...]
> > 
> >> Thank you,
> >> so you will send your patch? I prefer last version, to make testing
> >> easier.
> >
> > 
> >
> > I personally don't care. Feel free to fix your patch and send a new
> > version  (but think about adding the ":" after "install" -- the
> > character magically disappeared when I wrote the mail).
> >
> > 
> >
> > And don't forget the documentation part as it is always hard to remember 
> > everything on the day the release is made, but easy when you just made
> > the  patch. :)
> 
> Corrected.

Applied in revision 44a335d.

Next time, please send the patch inline again and add the branch name (batman-
adv in this case).

Thanks,
Marek