From: Marek Lindner <lindner_marek@yahoo.de>
To: The list for a Better Approach To Mobile Ad-hoc Networking
<b.a.t.m.a.n@lists.open-mesh.org>
Subject: Re: [B.A.T.M.A.N.] [PATCH 2/2] batctl: Explicitly mark the common header structure
Date: Tue, 22 Nov 2011 18:22:14 +0800 [thread overview]
Message-ID: <201111221822.14777.lindner_marek@yahoo.de> (raw)
In-Reply-To: <1321800459-15975-2-git-send-email-sven@narfation.org>
On Sunday, November 20, 2011 22:47:39 Sven Eckelmann wrote:
> All batman-adv packets have a common 3 byte header. It can be used to share
> some code between different code paths, but it was never explicit stated
> that this header has to be always the same for all packets. Therefore, new
> code changes always have the problem that they may accidently introduce
> regressions by moving some elements around.
>
> A new structure is introduced that contains the common header and makes it
> easier visible that these 3 bytes have to be the same for all on-wire
> packets.
Applied in revision 4c81da2.
Thanks,
Marek
next prev parent reply other threads:[~2011-11-22 10:22 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-20 14:47 [B.A.T.M.A.N.] [PATCH 1/2] batman-adv: Explicitly mark the common header structure Sven Eckelmann
2011-11-20 14:47 ` [B.A.T.M.A.N.] [PATCH 2/2] batctl: " Sven Eckelmann
2011-11-22 10:22 ` Marek Lindner [this message]
2011-11-22 10:20 ` [B.A.T.M.A.N.] [PATCH 1/2] batman-adv: " Marek Lindner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201111221822.14777.lindner_marek@yahoo.de \
--to=lindner_marek@yahoo.de \
--cc=b.a.t.m.a.n@lists.open-mesh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox