Re: [B.A.T.M.A.N.] [PATCHv4 1/7] batman-adv: implement an helper function to forge unicast packets

Andrew Lunn
2011-11-25T08:18:20Z

On Thu, Nov 24, 2011 at 11:21:13PM +0100, Antonio Quartulli wrote:
> A new function named prepare_unicast_packet() has been implemented so that it can
> do all the needed operations to set up a skb for unicast sending. It is general
> enough to be used in every context. Helpful for later developments
>
> Signed-off-by: Antonio Quartulli <ordex@autistici.org>
> ---
> unicast.c | 36 ++++++++++++++++++++++++------------
> unicast.h | 1 +
> 2 files changed, 25 insertions(+), 12 deletions(-)
>
> diff --git a/unicast.c b/unicast.c
> index 6f3c659..d49f2cc 100644
> --- a/unicast.c
> +++ b/unicast.c
> @@ -283,6 +283,29 @@ out:
> return ret;
> }
>
> +bool prepare_unicast_packet(struct sk_buff *skb, struct orig_node *orig_node)
> +{
> + struct unicast_packet *unicast_packet;
> +
> + if (my_skb_head_push(skb, sizeof(*unicast_packet)) < 0)
> + return false;
> +
> + unicast_packet = (struct unicast_packet *)skb->data;
> +
> + unicast_packet->header.version = COMPAT_VERSION;
> + /* batman packet type: unicast */
> + unicast_packet->header.packet_type = BAT_UNICAST;
> + /* set unicast ttl */
> + unicast_packet->header.ttl = TTL;

When Sven added this header structure, did he also add a function to
fill it in?

Andrew