Re: [B.A.T.M.A.N.] [PATCHv4 1/7] batman-adv: implement an helper function to forge unicast packets

Sven Eckelmann
2011-11-25T08:54:08Z

[-- Attachment #1: Type: text/plain, Size: 702 bytes --]

On Friday 25 November 2011 09:18:20 Andrew Lunn wrote:
[...]
> > + unicast_packet = (struct unicast_packet *)skb->data;
> > +
> > + unicast_packet->header.version = COMPAT_VERSION;
> > + /* batman packet type: unicast */
> > + unicast_packet->header.packet_type = BAT_UNICAST;
> > + /* set unicast ttl */
> > + unicast_packet->header.ttl = TTL;
>
> When Sven added this header structure, did he also add a function to
> fill it in?

No, I didn't. The header structure part was just the "keep it safe" thing. The
fancy stuff can come later. And I am not sure whether such a function would be
useful. More interesting would be the TTL cleanup that Linus proposed a long
time ago.

Kind regards,
Sven

[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 836 bytes --]