Re: [B.A.T.M.A.N.] [PATCH] batman-adv: add biggest_unsigned_int(x) macro

[Antonio Quartulli <ordex@autistici.org>]

On Fri, Nov 25, 2011 at 09:50:41AM +0100, Sven Eckelmann wrote:
> On Friday 25 November 2011 09:08:47 Marek Lindner wrote:
> [...]
> > > +/* Returns the biggest unsigned integer with the sizeof x */
> > > +#define biggest_unsigned_int(x) (~(x)0)
> > > +
> > 
> > The final conclusion of the IRC discussion might have escaped me but wasn't
> > there supposed to be a cast somewhere ?
> 
> There is a cast. The part "(x)" of "(~(x)0)" is the cast. And I don't think 
> that there was a final conclusion. I am not really convinced that this should 
> be part of batman-adv. Just look at include/linux/kernel.h for similar 
> functionality (but with predefined types). Maybe this would be the correct 
> position for such a macro? (I don't know it... just thinking out loud).

Might be a good idea to send it to the kernel ml, but as usual, I think
we should first include it in the batman-adv code (am I wrong or we are
still waiting for seq_before/after to be included somewhere?).

But I agree with you, I should also send this patch to the kerel ml.

Cheers,


-- 
Antonio Quartulli

..each of us alone is worth nothing..
Ernesto "Che" Guevara ☭