* [B.A.T.M.A.N.] [PATCH] batmand: Don't override CPPFLAGS set by user @ 2011-12-06 18:57 Sven Eckelmann 2011-12-06 19:53 ` elektra 0 siblings, 1 reply; 4+ messages in thread From: Sven Eckelmann @ 2011-12-06 18:57 UTC (permalink / raw) To: b.a.t.m.a.n Users or build servers may want to enable preprocessor specific options like -D_FORTIFY_SOURCE=2 that are usually placed in CPPFLAGS. The batmand makefile should not override these options to add own preprocessor variables. Signed-off-by: Sven Eckelmann <sven@narfation.org> --- Makefile | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/Makefile b/Makefile index 346b14a..65e0cf2 100755 --- a/Makefile +++ b/Makefile @@ -55,7 +55,7 @@ MANPAGE = man/batmand.8 # batmand flags and options CFLAGS += -pedantic -Wall -W -std=gnu99 -MD -CPPFLAGS = -DDEBUG_MALLOC -DMEMORY_USAGE -DPROFILE_DATA $(NO_POLICY_ROUTING) +CPPFLAGS += -DDEBUG_MALLOC -DMEMORY_USAGE -DPROFILE_DATA $(NO_POLICY_ROUTING) LDLIBS += -lpthread # disable verbose output -- 1.7.7.3 ^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [B.A.T.M.A.N.] [PATCH] batmand: Don't override CPPFLAGS set by user 2011-12-06 18:57 [B.A.T.M.A.N.] [PATCH] batmand: Don't override CPPFLAGS set by user Sven Eckelmann @ 2011-12-06 19:53 ` elektra 2011-12-07 7:20 ` Sven Eckelmann 0 siblings, 1 reply; 4+ messages in thread From: elektra @ 2011-12-06 19:53 UTC (permalink / raw) To: The list for a Better Approach To Mobile Ad-hoc Networking > Users or build servers may want to enable preprocessor specific options > like -D_FORTIFY_SOURCE=2 that are usually placed in CPPFLAGS. The batmand > makefile should not override these options to add own preprocessor > variables. > > Signed-off-by: Sven Eckelmann <sven@narfation.org> Applied in 9cd7382. Thanks! Cheers, Elektra ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [B.A.T.M.A.N.] [PATCH] batmand: Don't override CPPFLAGS set by user 2011-12-06 19:53 ` elektra @ 2011-12-07 7:20 ` Sven Eckelmann 2011-12-07 12:40 ` elektra 0 siblings, 1 reply; 4+ messages in thread From: Sven Eckelmann @ 2011-12-07 7:20 UTC (permalink / raw) To: b.a.t.m.a.n [-- Attachment #1: Type: text/plain, Size: 840 bytes --] On Tuesday 06 December 2011 20:53:53 elektra wrote: > > Users or build servers may want to enable preprocessor specific options > > > > like -D_FORTIFY_SOURCE=2 that are usually placed in CPPFLAGS. The > > batmand makefile should not override these options to add own > > preprocessor variables. > > > > Signed-off-by: Sven Eckelmann <sven@narfation.org> > > Applied in 9cd7382. It would be nice not to remove my authorship in git. It is enough to just save the mail in a textfile (mbox) and run `git am patch123.mbox` or `git am -s patch123.mbox` (this adds your Signed-off-by after my Signed-of-by). Now it looks [1] like you are the author and committer of the patch.... but you should only be the committer. Kind regards, Sven [1] http://git.open-mesh.org/?p=batmand.git;a=commitdiff;h=9cd7382f815fbebe25381d5ad5da4cd5074f20cc [-- Attachment #2: This is a digitally signed message part. --] [-- Type: application/pgp-signature, Size: 836 bytes --] ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [B.A.T.M.A.N.] [PATCH] batmand: Don't override CPPFLAGS set by user 2011-12-07 7:20 ` Sven Eckelmann @ 2011-12-07 12:40 ` elektra 0 siblings, 0 replies; 4+ messages in thread From: elektra @ 2011-12-07 12:40 UTC (permalink / raw) To: Sven Eckelmann; +Cc: b.a.t.m.a.n Hi - thanks for the tip! Cheers, Elektra ^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2011-12-07 12:40 UTC | newest] Thread overview: 4+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2011-12-06 18:57 [B.A.T.M.A.N.] [PATCH] batmand: Don't override CPPFLAGS set by user Sven Eckelmann 2011-12-06 19:53 ` elektra 2011-12-07 7:20 ` Sven Eckelmann 2011-12-07 12:40 ` elektra
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox