From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: From: Marek Lindner Date: Wed, 21 Dec 2011 03:15:01 +0800 References: <1324377504-20983-1-git-send-email-lindner_marek@yahoo.de> <201112210259.42387.lindner_marek@yahoo.de> <20111220.140209.618109781658024408.davem@davemloft.net> In-Reply-To: <20111220.140209.618109781658024408.davem@davemloft.net> MIME-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Message-Id: <201112210315.02171.lindner_marek@yahoo.de> Subject: Re: [B.A.T.M.A.N.] [PATCH] batman-adv: checkpatch cleanup - remove lines longer than 80 chars Reply-To: The list for a Better Approach To Mobile Ad-hoc Networking List-Id: The list for a Better Approach To Mobile Ad-hoc Networking List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: b.a.t.m.a.n@lists.open-mesh.org Cc: netdev@vger.kernel.org, David Miller On Wednesday, December 21, 2011 03:02:09 David Miller wrote: > From: Marek Lindner > Date: Wed, 21 Dec 2011 02:59:41 +0800 > > > On Wednesday, December 21, 2011 02:32:30 David Miller wrote: > >> From: Marek Lindner > >> Date: Tue, 20 Dec 2011 18:38:24 +0800 > >> > >> > The long line was introduced with b26e478f8f. > >> > > >> > Signed-off-by: Marek Lindner > >> > >> I'm not applying this. > >> > >> I tell people to make sure arguments line up correctly to the > >> openning parenthesis on the previous line, and that is what is > >> happening here. > > > > I am not against lining up the arguments but what about checkpatch ? Are > > we going to ignore the complaints or is this line limit about to be > > changed ? > > Refactor the code so that both constraints can be satisfied. > > Is this so hard to understand? Well, my crystal ball did not unveil that a checkpatch complaint you silently introduced would mean somebody else has to refactor the code. Guess I have to get a replacement unit. Cheers, Marek