* [B.A.T.M.A.N.] [PATCH] batman-adv: checkpatch cleanup - remove lines longer than 80 chars
@ 2011-12-20 10:38 Marek Lindner
2011-12-20 18:32 ` David Miller
0 siblings, 1 reply; 6+ messages in thread
From: Marek Lindner @ 2011-12-20 10:38 UTC (permalink / raw)
To: davem; +Cc: netdev, b.a.t.m.a.n, Marek Lindner
The long line was introduced with b26e478f8f.
Signed-off-by: Marek Lindner <lindner_marek@yahoo.de>
---
net/batman-adv/translation-table.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/net/batman-adv/translation-table.c b/net/batman-adv/translation-table.c
index ab8dea8..58361ed 100644
--- a/net/batman-adv/translation-table.c
+++ b/net/batman-adv/translation-table.c
@@ -679,7 +679,7 @@ void tt_global_del(struct bat_priv *bat_priv,
* 2) the client roamed to us => we can directly delete
* the global entry, since it is useless now. */
tt_local_entry = tt_local_hash_find(bat_priv,
- tt_global_entry->common.addr);
+ tt_global_entry->common.addr);
if (!tt_local_entry) {
tt_global_entry->common.flags |= TT_CLIENT_ROAM;
tt_global_entry->roam_at = jiffies;
--
1.7.5.4
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [B.A.T.M.A.N.] [PATCH] batman-adv: checkpatch cleanup - remove lines longer than 80 chars
2011-12-20 10:38 [B.A.T.M.A.N.] [PATCH] batman-adv: checkpatch cleanup - remove lines longer than 80 chars Marek Lindner
@ 2011-12-20 18:32 ` David Miller
2011-12-20 18:59 ` Marek Lindner
0 siblings, 1 reply; 6+ messages in thread
From: David Miller @ 2011-12-20 18:32 UTC (permalink / raw)
To: lindner_marek; +Cc: netdev, b.a.t.m.a.n
From: Marek Lindner <lindner_marek@yahoo.de>
Date: Tue, 20 Dec 2011 18:38:24 +0800
> The long line was introduced with b26e478f8f.
>
> Signed-off-by: Marek Lindner <lindner_marek@yahoo.de>
I'm not applying this.
I tell people to make sure arguments line up correctly to the
openning parenthesis on the previous line, and that is what is
happening here.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [B.A.T.M.A.N.] [PATCH] batman-adv: checkpatch cleanup - remove lines longer than 80 chars
2011-12-20 18:32 ` David Miller
@ 2011-12-20 18:59 ` Marek Lindner
2011-12-20 19:02 ` David Miller
0 siblings, 1 reply; 6+ messages in thread
From: Marek Lindner @ 2011-12-20 18:59 UTC (permalink / raw)
To: David Miller; +Cc: netdev, b.a.t.m.a.n
On Wednesday, December 21, 2011 02:32:30 David Miller wrote:
> From: Marek Lindner <lindner_marek@yahoo.de>
> Date: Tue, 20 Dec 2011 18:38:24 +0800
>
> > The long line was introduced with b26e478f8f.
> >
> > Signed-off-by: Marek Lindner <lindner_marek@yahoo.de>
>
> I'm not applying this.
>
> I tell people to make sure arguments line up correctly to the
> openning parenthesis on the previous line, and that is what is
> happening here.
I am not against lining up the arguments but what about checkpatch ? Are we
going to ignore the complaints or is this line limit about to be changed ?
Cheers,
Marek
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [B.A.T.M.A.N.] [PATCH] batman-adv: checkpatch cleanup - remove lines longer than 80 chars
2011-12-20 18:59 ` Marek Lindner
@ 2011-12-20 19:02 ` David Miller
2011-12-20 19:15 ` Marek Lindner
0 siblings, 1 reply; 6+ messages in thread
From: David Miller @ 2011-12-20 19:02 UTC (permalink / raw)
To: lindner_marek; +Cc: netdev, b.a.t.m.a.n
From: Marek Lindner <lindner_marek@yahoo.de>
Date: Wed, 21 Dec 2011 02:59:41 +0800
> On Wednesday, December 21, 2011 02:32:30 David Miller wrote:
>> From: Marek Lindner <lindner_marek@yahoo.de>
>> Date: Tue, 20 Dec 2011 18:38:24 +0800
>>
>> > The long line was introduced with b26e478f8f.
>> >
>> > Signed-off-by: Marek Lindner <lindner_marek@yahoo.de>
>>
>> I'm not applying this.
>>
>> I tell people to make sure arguments line up correctly to the
>> openning parenthesis on the previous line, and that is what is
>> happening here.
>
> I am not against lining up the arguments but what about checkpatch ? Are we
> going to ignore the complaints or is this line limit about to be changed ?
Refactor the code so that both constraints can be satisfied.
Is this so hard to understand?
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [B.A.T.M.A.N.] [PATCH] batman-adv: checkpatch cleanup - remove lines longer than 80 chars
2011-12-20 19:02 ` David Miller
@ 2011-12-20 19:15 ` Marek Lindner
2011-12-20 20:56 ` Ben Hutchings
0 siblings, 1 reply; 6+ messages in thread
From: Marek Lindner @ 2011-12-20 19:15 UTC (permalink / raw)
To: b.a.t.m.a.n; +Cc: netdev, David Miller
On Wednesday, December 21, 2011 03:02:09 David Miller wrote:
> From: Marek Lindner <lindner_marek@yahoo.de>
> Date: Wed, 21 Dec 2011 02:59:41 +0800
>
> > On Wednesday, December 21, 2011 02:32:30 David Miller wrote:
> >> From: Marek Lindner <lindner_marek@yahoo.de>
> >> Date: Tue, 20 Dec 2011 18:38:24 +0800
> >>
> >> > The long line was introduced with b26e478f8f.
> >> >
> >> > Signed-off-by: Marek Lindner <lindner_marek@yahoo.de>
> >>
> >> I'm not applying this.
> >>
> >> I tell people to make sure arguments line up correctly to the
> >> openning parenthesis on the previous line, and that is what is
> >> happening here.
> >
> > I am not against lining up the arguments but what about checkpatch ? Are
> > we going to ignore the complaints or is this line limit about to be
> > changed ?
>
> Refactor the code so that both constraints can be satisfied.
>
> Is this so hard to understand?
Well, my crystal ball did not unveil that a checkpatch complaint you silently
introduced would mean somebody else has to refactor the code. Guess I have to
get a replacement unit.
Cheers,
Marek
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [B.A.T.M.A.N.] [PATCH] batman-adv: checkpatch cleanup - remove lines longer than 80 chars
2011-12-20 19:15 ` Marek Lindner
@ 2011-12-20 20:56 ` Ben Hutchings
0 siblings, 0 replies; 6+ messages in thread
From: Ben Hutchings @ 2011-12-20 20:56 UTC (permalink / raw)
To: Marek Lindner; +Cc: netdev, b.a.t.m.a.n, David Miller
On Wed, 2011-12-21 at 03:15 +0800, Marek Lindner wrote:
> On Wednesday, December 21, 2011 03:02:09 David Miller wrote:
> > From: Marek Lindner <lindner_marek@yahoo.de>
> > Date: Wed, 21 Dec 2011 02:59:41 +0800
> >
> > > On Wednesday, December 21, 2011 02:32:30 David Miller wrote:
> > >> From: Marek Lindner <lindner_marek@yahoo.de>
> > >> Date: Tue, 20 Dec 2011 18:38:24 +0800
> > >>
> > >> > The long line was introduced with b26e478f8f.
> > >> >
> > >> > Signed-off-by: Marek Lindner <lindner_marek@yahoo.de>
> > >>
> > >> I'm not applying this.
> > >>
> > >> I tell people to make sure arguments line up correctly to the
> > >> openning parenthesis on the previous line, and that is what is
> > >> happening here.
> > >
> > > I am not against lining up the arguments but what about checkpatch ? Are
> > > we going to ignore the complaints or is this line limit about to be
> > > changed ?
> >
> > Refactor the code so that both constraints can be satisfied.
> >
> > Is this so hard to understand?
>
> Well, my crystal ball did not unveil that a checkpatch complaint you silently
> introduced would mean somebody else has to refactor the code. Guess I have to
> get a replacement unit.
No-one has to refactor the code. I think David's point is that he's
more concerned about proper alignment than having every line under 80
characters. If you want to satisfy the latter constraint, you still
have to satisfy the former.
Ben.
--
Ben Hutchings, Staff Engineer, Solarflare
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2011-12-20 20:56 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-12-20 10:38 [B.A.T.M.A.N.] [PATCH] batman-adv: checkpatch cleanup - remove lines longer than 80 chars Marek Lindner
2011-12-20 18:32 ` David Miller
2011-12-20 18:59 ` Marek Lindner
2011-12-20 19:02 ` David Miller
2011-12-20 19:15 ` Marek Lindner
2011-12-20 20:56 ` Ben Hutchings
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox