From: Marek Lindner <lindner_marek@yahoo.de>
To: The list for a Better Approach To Mobile Ad-hoc Networking
<b.a.t.m.a.n@lists.open-mesh.org>
Subject: Re: [B.A.T.M.A.N.] [RFC] batman-adv: Replace bitarray operations with bitmap [aka. lets break batman-av]
Date: Tue, 17 Jan 2012 07:00:12 +0800 [thread overview]
Message-ID: <201201170700.13365.lindner_marek@yahoo.de> (raw)
In-Reply-To: <1326223162-15181-1-git-send-email-sven@narfation.org>
Hi,
> bitarray.c consists mostly of functionality that is already available as
> part of the standard kernel API. batman-adv could use architecture
> optimized code and reduce the binary size by switching to the standard
> functions.
it took some time to read about the kernel bit functions but I think this is
the right way to go. From my end it looks pretty solid. Though I have 2
comments:
* get_bit_status()/bit_mark()/bit_shift() now are wrapper functions of the
linux kernel functions with an additional check. How about we follow the
kernel naming convention plus a small prefix ? For example:
bat_test_bit()/bat_set_bit()/bat_bitmap_shift_left() ? We probably could also
inline those 3 functions since they don't do much.
* Am I right assuming that you did not find something nice / handy for our
bitarrays bcast_own/bcast_own_sum ? At the moment we deal with them in a
"manual" fashion ..
Cheers,
Marek
next prev parent reply other threads:[~2012-01-16 23:00 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-10 19:19 [B.A.T.M.A.N.] [RFC] batman-adv: Replace bitarray operations with bitmap [aka. lets break batman-av] Sven Eckelmann
2012-01-16 23:00 ` Marek Lindner [this message]
2012-02-04 16:34 ` [B.A.T.M.A.N.] [RFCv2] batman-adv: Replace bitarray operations with bitmap Sven Eckelmann
2012-02-05 18:40 ` Marek Lindner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201201170700.13365.lindner_marek@yahoo.de \
--to=lindner_marek@yahoo.de \
--cc=b.a.t.m.a.n@lists.open-mesh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox