From: Simon Wunderlich <simon.wunderlich@s2003.tu-chemnitz.de>
To: The list for a Better Approach To Mobile Ad-hoc Networking
<b.a.t.m.a.n@lists.open-mesh.org>
Subject: Re: [B.A.T.M.A.N.] [RFCv2] batman-adv: Add blocking of one hop OGM messages
Date: Wed, 15 Feb 2012 20:23:21 +0100 [thread overview]
Message-ID: <20120215192321.GA24703@pandem0nium> (raw)
In-Reply-To: <1328885591-10445-1-git-send-email-martin@hundeboll.net>
[-- Attachment #1: Type: text/plain, Size: 1181 bytes --]
Hey Martin,
On Fri, Feb 10, 2012 at 03:53:11PM +0100, Martin Hundebøll wrote:
> 13 files changed, 491 insertions(+), 0 deletions(-)
please excuse my superficial review, but do we really need to bloat batman-adv
by 491 more lines to drop these OGMs? I'm afraid the filter will evolve
more and more, and eventually the research/debugging code in batman-adv
is bigger than the routing code. ;)
(sorry for ranting ;] )
Have you considered using and/or extending the former ebtables patch
from Linus[1]? We removed [2] it after some discussions [3], but maybe
its worth fixing these problems if its just about dropping some neighbors
packets. The patch has some problems, but it was really short and I guess
we wouldn't mind accepting the performance overhead by ebtables for
research/debugging purposes. Plus, we could make this a compile-feature too.
Cheers,
Simon
[1] http://ftp.uni-kl.de/pub/linux/kernel/people/gregkh/staging/2.6/2.6.35/0120-Staging-batman-adv-Adding-netfilter-bridge-hooks.patch
[2] https://lists.open-mesh.org/pipermail/b.a.t.m.a.n/2010-September/003305.html
[3] http://lkml.indiana.edu/hypermail/linux/kernel/1008.1/02232.html
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 198 bytes --]
next prev parent reply other threads:[~2012-02-15 19:23 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-08 19:05 [B.A.T.M.A.N.] [RFC] batman-adv: Add filtering of OGM messages Martin Hundebøll
2012-02-08 19:53 ` Antonio Quartulli
2012-02-09 7:59 ` Marek Lindner
2012-02-10 14:53 ` [B.A.T.M.A.N.] [RFCv2] batman-adv: Add blocking of one hop " Martin Hundebøll
2012-02-10 14:56 ` Martin Hundebøll
2012-02-15 19:23 ` Simon Wunderlich [this message]
2012-02-16 10:54 ` Martin Hundebøll
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120215192321.GA24703@pandem0nium \
--to=simon.wunderlich@s2003.tu-chemnitz.de \
--cc=b.a.t.m.a.n@lists.open-mesh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox