From: Antonio Quartulli <ordex@autistici.org>
To: The list for a Better Approach To Mobile Ad-hoc Networking
<b.a.t.m.a.n@lists.open-mesh.org>
Subject: Re: [B.A.T.M.A.N.] [PATCH] batman-adv: use ETH_HLEN instead of sizeof(struct ethhdr)
Date: Fri, 17 Feb 2012 11:29:30 +0100 [thread overview]
Message-ID: <20120217101933.GA2194@ritirata.org> (raw)
In-Reply-To: <201202171805.42454.lindner_marek@yahoo.de>
[-- Attachment #1: Type: text/plain, Size: 580 bytes --]
On Fri, Feb 17, 2012 at 06:05:42 +0800, Marek Lindner wrote:
> On Thursday, February 16, 2012 07:40:00 Antonio Quartulli wrote:
> > Instead of using sizeof(struct ethhdr) it is strongly recommended to use
> > the kernel macro ETH_HLEN. This patch substitute each occurrence of the
> > former expressione with the latter one.
>
> You have missed 2 incarnations. :)
> Check bridge_loop_avoidance.c line 859 and send.c line 54.
Oh, thanks.
I'll send v2
>
> Cheers,
> Marek
--
Antonio Quartulli
..each of us alone is worth nothing..
Ernesto "Che" Guevara
[-- Attachment #2: Type: application/pgp-signature, Size: 490 bytes --]
next prev parent reply other threads:[~2012-02-17 10:29 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-15 23:40 [B.A.T.M.A.N.] [PATCH] batman-adv: use ETH_HLEN instead of sizeof(struct ethhdr) Antonio Quartulli
2012-02-17 10:05 ` Marek Lindner
2012-02-17 10:29 ` Antonio Quartulli [this message]
2012-02-18 10:27 ` [B.A.T.M.A.N.] [PATCHv2] " Antonio Quartulli
2012-02-20 10:21 ` Marek Lindner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120217101933.GA2194@ritirata.org \
--to=ordex@autistici.org \
--cc=b.a.t.m.a.n@lists.open-mesh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox