Re: [B.A.T.M.A.N.] [PATCH 5/5] batman-adv: avoid temporary routing loops by being strict on forwarded OGMs

Daniele Furlan
2012-03-12T07:49:26Z

2012/3/12 Marek Lindner <lindner_marek@yahoo.de>:
>
> Hi,
>
>> I agree with this patch, actually it should solve the loop problem as it is
>> very similar to the proposed modification in my thesis.
>
> thanks for the feedback!
>
>
>> In this way I think it is not necessary a global window to average TQ
>> values but only the latest value can be sufficient. Doing this can be
>> re-implemented a mechanism to improve OGM reliability sending old TQ ant
>> TTL (and also sequence number) of the current best router if for example 2
>> OGM are missing.
>
> I don't quite understand what you are proposing. Are you saying removing the
> averaging mechanism makes this patch obsolete and allows replacing the TTL/TQ
> values as the code does now (without the patch) ?
>
No no this patch is good, the removing of TQ average can be a following step
as now average is not forwarded anymore, but only used as a comparative
value between path in another point of the source code.

Also the mechanism of forwarding OGM even if it does not come from the best
router can be added later, on top of this patch.

> Cheers,
> Marek

--
Daniele Furlan