* [B.A.T.M.A.N.] [PATCH] batman-adv: avoid skb_linearise() if not needed
@ 2012-03-16 10:52 Antonio Quartulli
2012-03-20 12:59 ` Marek Lindner
0 siblings, 1 reply; 2+ messages in thread
From: Antonio Quartulli @ 2012-03-16 10:52 UTC (permalink / raw)
To: b.a.t.m.a.n
Whenever we want to access headers only, we do not need to linearise the whole
packet. Instead we can use pskb_may_pull()
Signed-off-by: Antonio Quartulli <ordex@autistici.org>
---
routing.c | 5 +++--
1 files changed, 3 insertions(+), 2 deletions(-)
diff --git a/routing.c b/routing.c
index 962a315..576ffb1 100644
--- a/routing.c
+++ b/routing.c
@@ -915,8 +915,9 @@ static int check_unicast_ttvn(struct bat_priv *bat_priv,
/* Check whether I have to reroute the packet */
if (seq_before(unicast_packet->ttvn, curr_ttvn) || tt_poss_change) {
- /* Linearize the skb before accessing it */
- if (skb_linearize(skb) < 0)
+ /* check if there is enough data before accessing it */
+ if (pskb_may_pull(skb, sizeof(struct unicast_packet) +
+ ETH_HLEN) < 0)
return 0;
ethhdr = (struct ethhdr *)(skb->data +
--
1.7.3.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [B.A.T.M.A.N.] [PATCH] batman-adv: avoid skb_linearise() if not needed
2012-03-16 10:52 [B.A.T.M.A.N.] [PATCH] batman-adv: avoid skb_linearise() if not needed Antonio Quartulli
@ 2012-03-20 12:59 ` Marek Lindner
0 siblings, 0 replies; 2+ messages in thread
From: Marek Lindner @ 2012-03-20 12:59 UTC (permalink / raw)
To: The list for a Better Approach To Mobile Ad-hoc Networking
On Friday, March 16, 2012 11:52:31 Antonio Quartulli wrote:
> Whenever we want to access headers only, we do not need to linearise the
> whole packet. Instead we can use pskb_may_pull()
Applied in revision 782b0f4.
Thanks,
Marek
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2012-03-20 12:59 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-03-16 10:52 [B.A.T.M.A.N.] [PATCH] batman-adv: avoid skb_linearise() if not needed Antonio Quartulli
2012-03-20 12:59 ` Marek Lindner
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox