Re: [B.A.T.M.A.N.] [RFC 1/5] batman-adv: ELP - adding basic infrastructure

Andrew Lunn
2012-03-23T06:50:44Z

> --- a/packet.h
> +++ b/packet.h
> @@ -33,7 +33,8 @@ enum bat_packettype {
> BAT_UNICAST_FRAG = 0x06,
> BAT_TT_QUERY = 0x07,
> BAT_ROAM_ADV = 0x08,
> - BAT_UNICAST_4ADDR = 0x09
> + BAT_UNICAST_4ADDR = 0x09,
> + BAT_V_ELP = 0x10
> };

Hi Marek

I guess you are not on the ARM linux kernel list. A couple of months
ago, Rusty had a rant about the last entry in such structures should
always have a , even though its optional. As part of the ARM cleanup
work he had to append a new entry to many board files, and found it
very error prone. Sometime you forget to add the , to the line before,
and then the compiler spits out a compile error. So since then i've
got into the habit of always having a , on the last entry.

Andrew