Re: [B.A.T.M.A.N.] [RFC 5/5] batman-adv: ELP - add configurable minimum ELP packet length (def: 300B)

Andrew Lunn
2012-03-24T20:39:45Z

> + if (skb->len < min_len) {
> + memset(elp_neigh_entry, 0, min_len - skb->len);
> + skb_put(skb, min_len - skb->len);
> + }
> +

Hi Marek

I don't know the skbuf code too well, maybe you know it better than
me.

Is this memset needed? The skb is a copy of the template ELP packet
created then the soft interface is created. So if the contents of the
template is set to 0, should we be able to skip this zeroing here?

Thanks
Andrew