Re: [B.A.T.M.A.N.] [PATCH 0/3] clean up patches

[Simon Wunderlich <simon.wunderlich@s2003.tu-chemnitz.de>]

[-- Attachment #1: Type: text/plain, Size: 1345 bytes --]

Hey Antonio,

thanks a lot for fixing my style bugs!!

There is a little bug in one (one line doubled), otherwise:

Reviewed-by: Simon Wunderlich <siwu@hrz.tu-chemnitz.de>

Cheers,
	Simon

On Sat, Apr 07, 2012 at 11:06:06PM +0200, Antonio Quartulli wrote:
> ** this patches are for batman-ad/next ***
> 
> After my first pull request, David S. Miller hardly suggested me to fix some
> problems that I am going to summarise here. Please respect such suggestions in
> your next patches:
> 
> 1) Multi-line comments must end with */ on a new line:
> 
> /* ..
>  * ..
>  */
> 
> 2) if we use #ifdef in our headers to redefine some functions depending on the
> fact that we are compiling a component or not, we must use static inline
> functions doing nothing with the correct parameters instead of simple
> "foo(...)". In this way we can allow the compiler to check for the types and the
> number of arguments:
> 
> Instead of:
> 
> #define bla_init(...) (1)
> 
> we must do:
> 
> static inline bla_init(struct bat_priv *bat_priv)
> { 
> 	return 1;
> }
> 
> 
> Other than David's complaining I also get a suggestion from Bernd Petrovitsch
> about the type of stp_addr (it should be "static const uint8_t []" instead of
> "uint8_t []" only). I applied such change in patch 2/3.
> 
> Cheers,
> 
> 
> 

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 198 bytes --]