From: Marek Lindner <lindner_marek@yahoo.de>
To: The list for a Better Approach To Mobile Ad-hoc Networking
<b.a.t.m.a.n@lists.open-mesh.org>
Subject: Re: [B.A.T.M.A.N.] [RFC 1/2] batman-adv: Add interface to keep stats
Date: Tue, 10 Apr 2012 14:31:40 +0300 [thread overview]
Message-ID: <201204101431.41143.lindner_marek@yahoo.de> (raw)
In-Reply-To: <4F8416C8.6010701@hundeboll.net>
On Tuesday, April 10, 2012 14:17:28 Martin Hundebøll wrote:
> >>> If you add an ifdef around the definition here would be no need to
> >>> malloc bat_stats separately, right ?
> >>
> >> Do we prefer IFDEFs in the definition over mallocs? (I guess so by your
> >> comment). If thats the case, then no problem with me.
> >
> > The types.h is full of ifdefs already. It helps to keep the structs
> > smaller when functionality is not compiled into the module.
>
> As long as we agree on ifdefs. They weren't there until BLAII and DAT added
> them, but I don't have a problem with'em. Let's see how long this
> patch-set will live, as I expect to use the get_ethtool_stats(), if
> possible.
Some of the counters might exist in bat_priv->stats as Antonio already pointed
out (bat_priv->stats.rx_packets). They have the advantage of being printed
with ifconfig and friends.
Regards,
Marek
next prev parent reply other threads:[~2012-04-10 11:31 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-02 12:48 [B.A.T.M.A.N.] [RFC 0/2] Create counters for measuring behaviour Martin Hundebøll
2012-04-02 12:48 ` [B.A.T.M.A.N.] [RFC 1/2] batman-adv: Add interface to keep stats Martin Hundebøll
2012-04-04 8:07 ` Marek Lindner
2012-04-10 10:33 ` Martin Hundebøll
2012-04-10 11:05 ` Marek Lindner
2012-04-10 11:17 ` Martin Hundebøll
2012-04-10 11:31 ` Marek Lindner [this message]
2012-04-02 12:48 ` [B.A.T.M.A.N.] [RFC 2/2] batman-adv: Increment stat counters on rx, tx, fwd Martin Hundebøll
2012-04-04 8:08 ` [B.A.T.M.A.N.] [RFC 0/2] Create counters for measuring behaviour Marek Lindner
2012-04-10 10:34 ` Martin Hundebøll
2012-04-10 11:08 ` Marek Lindner
2012-04-10 11:18 ` Martin Hundebøll
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201204101431.41143.lindner_marek@yahoo.de \
--to=lindner_marek@yahoo.de \
--cc=b.a.t.m.a.n@lists.open-mesh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox