Re: [B.A.T.M.A.N.] [PATCHv3 3/3] batman-adv: use static inline functions to fake not compiled-in routines

Antonio Quartulli
2012-04-13T22:13:52Z

[-- Attachment #1: Type: text/plain, Size: 1020 bytes --]

On Fri, Apr 13, 2012 at 11:04:23 +0200, Marek Lindner wrote:
> On Thursday, April 12, 2012 09:07:29 Antonio Quartulli wrote:
> > In case of not compiled-in components, we need to fake some functions in
> > order to let the rest of the code correctly build. But instead of using
> > something like:
> >
> > We have to use:
> >
> > static inline bla_init(struct bat_priv *bat_priv)
> > {
> > return 1;
> > }
> >
> > In this way the compiler can correctly check the type and the number of the
> > arguments passed to the function, even if the related component (bla in
> > this case) is not compiled.
>
> The same needs to be done for DAT, right ?

Exactly.
the next pull request should contain this change also for DAT. Moreover we
should provide a sysfs mechanism enable/disable DAT at runtime, so that people
can disable it on all the nodes without the need of rebuilding the module.

Cheers,

--
Antonio Quartulli

..each of us alone is worth nothing..
Ernesto "Che" Guevara

[-- Attachment #2: Type: application/pgp-signature, Size: 490 bytes --]