Re: [B.A.T.M.A.N.] [PATCH 0/2] Fixes reported by Al Viro

[Antonio Quartulli <ordex@autistici.org>]

[-- Attachment #1: Type: text/plain, Size: 958 bytes --]

On Sat, Apr 14, 2012 at 01:15:25PM +0200, Antonio Quartulli wrote:
> The following two patches fix the two issues found by Al Viro and reported in
> his email.
> 
> Patch 1) simply convert the tt_crc field in the bat_priv structure from atomic_t
> to uint16_t. Actually there is no reason to declare it as atomic_t.
> 
> Patch 2) fixes a little bug we have when sending a tt_request message: now we
> don't convert the tt_crc that we are sending within the request to network
> order. OTOH we convert this field from NO to HO on the receiver side.
> 
> Therefore, nodes on the path of the request, which have HO different from NO,
> will fail to reply to the request and will forward it towards the final
> destination.

I think David'd want to see this fix in the next pull request or so...should we
commit these patches to next directly?

Cheers,

-- 
Antonio Quartulli

..each of us alone is worth nothing..
Ernesto "Che" Guevara

[-- Attachment #2: Type: application/pgp-signature, Size: 490 bytes --]