From: Antonio Quartulli <ordex@autistici.org>
To: The list for a Better Approach To Mobile Ad-hoc Networking
<b.a.t.m.a.n@lists.open-mesh.org>
Cc: "Martin Hundebøll" <martin@hundeboll.net>
Subject: Re: [B.A.T.M.A.N.] [PATCH] batman-adv: Add get_ethtool_stats() support
Date: Tue, 17 Apr 2012 09:25:38 +0200 [thread overview]
Message-ID: <20120417072537.GB32239@ritirata.org> (raw)
In-Reply-To: <20120417071241.GA32239@ritirata.org>
[-- Attachment #1: Type: text/plain, Size: 1369 bytes --]
On Tue, Apr 17, 2012 at 09:12:42AM +0200, Antonio Quartulli wrote:
> On Tue, Apr 17, 2012 at 01:24:55 +0200, Martin Hundebøll wrote:
> > +static void bat_get_ethtool_stats(struct net_device *dev,
> > + struct ethtool_stats *stats, u64 *data)
> > +{
> > + struct bat_priv *bat_priv = netdev_priv(dev);
> > +
> > + data[0] = bat_priv->bat_stats.forward;
> > + data[1] = bat_priv->bat_stats.mgmt_tx;
> > + data[2] = bat_priv->bat_stats.mgmt_rx;
> > + data[3] = bat_priv->bat_stats.tt_request_tx;
> > + data[4] = bat_priv->bat_stats.tt_request_rx;
> > + data[5] = bat_priv->bat_stats.tt_response_tx;
> > + data[6] = bat_priv->bat_stats.tt_response_rx;
> > + data[7] = bat_priv->bat_stats.tt_roam_adv_tx;
> > + data[8] = bat_priv->bat_stats.tt_roam_adv_rx;
> > + data[9] = bat_priv->bat_stats.dat_request_tx;
> > + data[10] = bat_priv->bat_stats.dat_request_rx;
> > + data[11] = bat_priv->bat_stats.dat_reply_tx;
> > + data[12] = bat_priv->bat_stats.dat_reply_rx;
> > +}
>
> (guess mode ON) why using u64? what if the arch is 32bit? are the values
> correctly assigned anyway? what about longer addresses (do they exist?)?
> As Sven suggested on IRC, you probably want to use uintptr_t instead.
Sorry drop this part. I need to sleep more. Damn.
--
Antonio Quartulli
..each of us alone is worth nothing..
Ernesto "Che" Guevara
[-- Attachment #2: Type: application/pgp-signature, Size: 490 bytes --]
next prev parent reply other threads:[~2012-04-17 7:25 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-16 23:24 [B.A.T.M.A.N.] [PATCH] batman-adv: Add get_ethtool_stats() support Martin Hundebøll
2012-04-17 7:12 ` Antonio Quartulli
2012-04-17 7:25 ` Antonio Quartulli [this message]
2012-04-17 13:22 ` Martin Hundebøll
2012-04-17 8:19 ` Marek Lindner
2012-04-17 13:24 ` Martin Hundebøll
2012-04-17 13:29 ` Antonio Quartulli
2012-04-17 16:52 ` [B.A.T.M.A.N.] [PATCHv2] " Martin Hundebøll
2012-04-18 13:35 ` [B.A.T.M.A.N.] [PATCHv3] " Martin Hundebøll
2012-04-20 8:13 ` Marek Lindner
2012-04-20 15:02 ` [B.A.T.M.A.N.] [PATCHv4] " Martin Hundebøll
2012-04-22 9:03 ` Marek Lindner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120417072537.GB32239@ritirata.org \
--to=ordex@autistici.org \
--cc=b.a.t.m.a.n@lists.open-mesh.org \
--cc=martin@hundeboll.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox