From: Antonio Quartulli <ordex@autistici.org>
To: David Miller <davem@davemloft.net>
Cc: netdev@vger.kernel.org, b.a.t.m.a.n@lists.open-mesh.org
Subject: Re: [B.A.T.M.A.N.] [PATCH 10/11] batman-adv: print OGM seq numbers as unsigned long
Date: Wed, 18 Apr 2012 09:24:50 +0200 [thread overview]
Message-ID: <20120418072449.GE27966@ritirata.org> (raw)
In-Reply-To: <20120418070134.GD27966@ritirata.org>
[-- Attachment #1: Type: text/plain, Size: 1269 bytes --]
On Wed, Apr 18, 2012 at 09:01:35AM +0200, Antonio Quartulli wrote:
> On Wed, Apr 18, 2012 at 08:47:00AM +0200, Antonio Quartulli wrote:
> > On Tue, Apr 17, 2012 at 10:47:46 -0400, David Miller wrote:
> > > From: Antonio Quartulli <ordex@autistici.org>
> > > Date: Tue, 17 Apr 2012 13:58:26 +0200
> > >
> > > > OGM sequence numbers are declared as uint32_t and so they have to printed
> > > > using %u instead of %d in order to avoid wrong representations.
> > > >
> > > > Signed-off-by: Antonio Quartulli <ordex@autistici.org>
> > >
> > > Fix this commit message subject, "%u" is "unsigned int" not
> > > "unsigned long"
> > >
> > > "unsigned long" would be "%lu"
>
> There is a problem here. On my machine (x86_64) I have:
>
> typedef unsigned int __u32;
> typedef __u32 uint32_t;
>
>
> So I should use %u to print my uint32_t variable (as I reported in my commit
> message).
>
> Probably this is not the case on each and every architecture?
> If so, how could I handle it?
Ok. After digging in the code again I understood that the problem is either in
my brain and in the commit subject.
I'll fix both.
Cheers,
--
Antonio Quartulli
..each of us alone is worth nothing..
Ernesto "Che" Guevara
[-- Attachment #2: Type: application/pgp-signature, Size: 490 bytes --]
next prev parent reply other threads:[~2012-04-18 7:24 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-17 11:58 [B.A.T.M.A.N.] pull request: batman-adv 2012-04-17 Antonio Quartulli
2012-04-17 11:58 ` [B.A.T.M.A.N.] [PATCH 01/11] batman-adv: move ogm initialization into the proper function Antonio Quartulli
2012-04-17 11:58 ` [B.A.T.M.A.N.] [PATCH 02/11] batman-adv: refactoring API: find generalized name for bat_ogm_init callback Antonio Quartulli
2012-04-17 11:58 ` [B.A.T.M.A.N.] [PATCH 03/11] batman-adv: randomize initial seqno to avoid collision Antonio Quartulli
2012-04-18 2:45 ` David Miller
2012-04-18 6:42 ` Antonio Quartulli
2012-04-17 11:58 ` [B.A.T.M.A.N.] [PATCH 04/11] batman-adv: add iface_disable() callback to routing API Antonio Quartulli
2012-04-17 11:58 ` [B.A.T.M.A.N.] [PATCH 05/11] batman-adv: handle routing code initialization properly Antonio Quartulli
2012-04-18 2:46 ` David Miller
2012-04-18 6:45 ` Antonio Quartulli
2012-04-17 11:58 ` [B.A.T.M.A.N.] [PATCH 06/11] batman-adv: refactoring API: find generalized name for bat_ogm_init_primary callback Antonio Quartulli
2012-04-17 11:58 ` [B.A.T.M.A.N.] [PATCH 07/11] batman-adv: rename BATMAN_OGM_LEN to BATMAN_OGM_HLEN Antonio Quartulli
2012-04-17 11:58 ` [B.A.T.M.A.N.] [PATCH 08/11] batman-adv: mark existing ogm variables as batman iv Antonio Quartulli
2012-04-17 11:58 ` [B.A.T.M.A.N.] [PATCH 09/11] batman-adv: use ETH_HLEN instead of sizeof(struct ethhdr) Antonio Quartulli
2012-04-17 11:58 ` [B.A.T.M.A.N.] [PATCH 10/11] batman-adv: print OGM seq numbers as unsigned long Antonio Quartulli
2012-04-18 2:47 ` David Miller
2012-04-18 6:47 ` Antonio Quartulli
2012-04-18 7:01 ` Antonio Quartulli
2012-04-18 7:24 ` Antonio Quartulli [this message]
2012-04-18 7:28 ` David Miller
2012-04-17 11:58 ` [B.A.T.M.A.N.] [PATCH 11/11] batman-adv: skip the window protection test when the originator has no neighbours Antonio Quartulli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120418072449.GE27966@ritirata.org \
--to=ordex@autistici.org \
--cc=b.a.t.m.a.n@lists.open-mesh.org \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox